Fix undefined behavior in recalc_hp (#36470)

This is triggered during character creation. src/character.cpp:1114:66: runtime error: division by zero SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/character.cpp:1114:66 in src/character.cpp:1116:21: runtime error: -nan is outside the range of representable values of type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/character.cpp:1116:21 in
CleverRaven · Dec 26, 2019 · 9e77218 · 9e77218
2 parents 1f92726 + b9ef7ab
commit 9e77218
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/character.cpp b/src/character.cpp
@@ -1111,6 +1111,10 @@ void Character::recalc_hp()
         if( new_max_hp[i] == hp_max[i] ) {
             continue;
         }
+        // Avoid NaN because converting NaN to int is undefined behavior.
+        if( hp_max[i] == 0 ) {
+            continue;
+        }
         float max_hp_ratio = static_cast<float>( new_max_hp[i] ) /
                              static_cast<float>( hp_max[i] );
         hp_cur[i] = std::ceil( static_cast<float>( hp_cur[i] ) * max_hp_ratio );