Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-after-free in translations.cpp #36467

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Dec 26, 2019

Summary

SUMMARY: None

Purpose of change

Fix a case of use-after-free in a lambda in translation.cpp

Describe the solution

Capture by value instead of by reference.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Translation I18n labels Dec 26, 2019
@ZhilkinSerg ZhilkinSerg merged commit 9a9104f into CleverRaven:master Dec 26, 2019
@Qrox Qrox deleted the fix-use-after-free branch December 28, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants