Replaced balance, claim, & transaction history actions/reducers with new actions architecture #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuggins
changed the title
mhuggins
changed the title
evgenyboxer
approved these changes
Jan 28, 2018
|
Fantastic work @mhuggins |
mhuggins
force-pushed
the
balance-actions
branch
from
f2250e1 to
2812ecc
Compare
|
@evgenyboxer Rebased. |
|
Looks like another intermittent failure on these end-to-end tests. These were working prior to rebasing. Can someone kick off the circle test to retry? /cc @evgenyboxer |
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Feb 3, 2018
…new actions architecture (#611) * Added actions for fetching asset & token balances * Removed unused prop mapping from app store * Added balance actions and HOC's to replaced most of loadWalletData function * Reset stores on logout * Renamed accountActions to authActions * Removed unused deprecated functions * Fixed fetching state from action that has not been fetched * Added claims actions and account actions * Replaced load wallet claim sync with new action data * Replaced load wallet transactions sync with new action data * Fixed tokens argument being passed to account request action
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Feb 14, 2018
…new actions architecture (#611) * Added actions for fetching asset & token balances * Removed unused prop mapping from app store * Added balance actions and HOC's to replaced most of loadWalletData function * Reset stores on logout * Renamed accountActions to authActions * Removed unused deprecated functions * Fixed fetching state from action that has not been fetched * Added claims actions and account actions * Replaced load wallet claim sync with new action data * Replaced load wallet transactions sync with new action data * Fixed tokens argument being passed to account request action
mhuggins
added a commit
to neoverse/neon-wallet
that referenced
this pull request
Feb 22, 2018
…new actions architecture (CityOfZion#611) * Added actions for fetching asset & token balances * Removed unused prop mapping from app store * Added balance actions and HOC's to replaced most of loadWalletData function * Reset stores on logout * Renamed accountActions to authActions * Removed unused deprecated functions * Fixed fetching state from action that has not been fetched * Added claims actions and account actions * Replaced load wallet claim sync with new action data * Replaced load wallet transactions sync with new action data * Fixed tokens argument being passed to account request action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
N/A
What problem does this PR solve?
This is a continuation of the redux refactor from PR's #542, #575, #586, and #595. It replaces most of the claim & wallet actions & reducers with a new set of actions for fetching balances, available claims, and transaction history. It also renames the accountActions to authActions for clarity.
In addition to this work, I also:
loadWalletDatafunction and replaced it with a batch request in the new redux architecture (a long time coming!).withResponsiveAction: perform an action when a prop changes or condition is met.withReset: resets data in a portion of the store when a prop changes or condition is met.withLogoutReset: resets action data when the user logs out.testHelpers.jsfile to help consolidate repetitive test code.How did you solve this problem?
I added new actions for fetching balances, claims, and transaction history using the new actions architecture.
How did you make sure your solution works?
I smoke tested and addressed any test failures associated with these changes.
Are there any special changes in the code that we should be aware of?
N/A
Is there anything else we should know?
N/A