Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced price actions/reducers with new actions architecture #595

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

mhuggins
Copy link
Contributor

What current issue(s) from Trello/Github does this address?
N/A

What problem does this PR solve?
This is a continuation of the redux refactor from PR's #542, #575, and #586. It replaces the price actions & reducers with a new set of actions for fetching NEO/GAS prices.

How did you solve this problem?
I added a new action for fetching prices using the new actions architecture.

How did you make sure your solution works?
I smoke tested and updated tests.

Are there any special changes in the code that we should be aware of?
N/A

Is there anything else we should know?
N/A

  • Unit tests written?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 36.966% when pulling afd9913 on neoverse:price-actions into dd43fb3 on CityOfZion:dev.

Copy link
Contributor

@evgenyboxer evgenyboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants