Replaced authentication actions/reducers with new actions architecture #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuggins
force-pushed
the
auth-actions2
branch
from
d912a0b to
6d7aa10
Compare
mhuggins
force-pushed
the
auth-actions2
branch
3 times, most recently
from
bed2dfb to
dc14e89
Compare
mhuggins
changed the title
1 task
mhuggins
force-pushed
the
auth-actions2
branch
from
dc14e89 to
3ef8d97
Compare
Merged
1 task
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Feb 3, 2018
#586) * Add failed screen when data can't be fetched * Replaced module auth functions with actions * Fixed withData to account for data not being loaded yet * Added redirects when user logs in or out * Added error notifications to login actions * Fixed showing back to back error notifications * Added wallet reload when network changes
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Feb 14, 2018
#586) * Add failed screen when data can't be fetched * Replaced module auth functions with actions * Fixed withData to account for data not being loaded yet * Added redirects when user logs in or out * Added error notifications to login actions * Fixed showing back to back error notifications * Added wallet reload when network changes
mhuggins
added a commit
to neoverse/neon-wallet
that referenced
this pull request
Feb 22, 2018
CityOfZion#586) * Add failed screen when data can't be fetched * Replaced module auth functions with actions * Fixed withData to account for data not being loaded yet * Added redirects when user logs in or out * Added error notifications to login actions * Fixed showing back to back error notifications * Added wallet reload when network changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
N/A
What problem does this PR solve?
This is a continuation of the redux refactor from PR's #542 and #575. It replaces the
accountsactions & reducers with a new set of actions & higher-order components for logging in through the various mechanisms & logging out.This also introduces a couple other changes and fixes:
withDatato account for data not being fetched yet.How did you solve this problem?
I added several new actions for logging in and out. I also introduced a handful of new higher-order components:
withAccountDatapasses account data down to components.withLoginRedirectwatches for account redux state change to redirect to the dashboard.withLogoutRedirectwatches for account redux state change to redirect back to the home screen.withFailureNotificationwatches the failed actions and displays an error notification accordingly.How did you make sure your solution works?
I smoke tested as best I could. This is still a WIP because I need to do more thorough QA. I also need help with the ledger path because I don't have one yet, and I just had to guess my way through that code path.
Are there any special changes in the code that we should be aware of?
N/A
Is there anything else we should know?
I need help testing the ledger code changes. I don't have a ledger, and they're sold out until March. 😞