Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem rendering norbornene #34

Closed
MikeWilliams-UK opened this issue Feb 11, 2020 · 5 comments
Closed

Problem rendering norbornene #34

MikeWilliams-UK opened this issue Feb 11, 2020 · 5 comments
Assignees
Labels
Bug Something isn't working Fixed Fixed, but may not be released yet

Comments

@MikeWilliams-UK
Copy link
Contributor

I was trying to draw norbornene and the double bond turned in to a little dot.
2020-02-10_02-22-24

Originally posted by @tomyan112 in #33 (comment)

@MikeWilliams-UK MikeWilliams-UK added the Bug Something isn't working label Feb 11, 2020
@MikeWilliams-UK
Copy link
Contributor Author

Can you please post the CML for this structure to allow us to investigate?

<cml:cml xmlns:conventions="http://www.xml-cml.org/convention/"
               xmlns:cml="http://www.xml-cml.org/schema"
               xmlns:cmlDict="http://www.xml-cml.org/dictionary/cml/"
               xmlns:nameDict="http://www.xml-cml.org/dictionary/cml/name/"
               xmlns:c4w="http://www.chem4word.com/cml"
               conventions="convention:molecular">
  <cml:molecule id="m1">
    <cml:atomArray>
      <cml:atom id="a1" elementType="C" x2="495" y2="390.7313" />
      <cml:atom id="a2" elementType="C" x2="475.6815" y2="395.9077" />
      <cml:atom id="a3" elementType="C" x2="514.3185" y2="395.9077" />
      <cml:atom id="a4" elementType="C" x2="485.6815" y2="378.5872" />
      <cml:atom id="a5" elementType="C" x2="524.3185" y2="378.5872" />
      <cml:atom id="a6" elementType="C" x2="505" y2="373.4108" />
      <cml:atom id="a7" elementType="C" x2="499.8236" y2="354.0923" />
    </cml:atomArray>
    <cml:bondArray>
      <cml:bond id="b1" atomRefs2="a2 a1" order="S" />
      <cml:bond id="b2" atomRefs2="a1 a3" order="S" />
      <cml:bond id="b3" atomRefs2="a2 a4" order="D" c4w:placement="Anticlockwise" />
      <cml:bond id="b4" atomRefs2="a3 a5" order="S" />
      <cml:bond id="b5" atomRefs2="a4 a6" order="S" />
      <cml:bond id="b6" atomRefs2="a6 a5" order="S" />
      <cml:bond id="b7" atomRefs2="a6 a7" order="S" />
      <cml:bond id="b8" atomRefs2="a7 a1" order="S" />
    </cml:bondArray>
  </cml:molecule>
</cml:cml>

@MikeWilliams-UK
Copy link
Contributor Author

In the attached image I have turned on a couple of diagnostic features which allow us to diagnose issues.

Green spots show the detected centre of rings.
The dotted lines show how the extra bond line which is initially parallel to and the same size as the main bond line is clipped.

In the case of this structure, it is the calculation of the ring centre which is at fault.

image

@MikeWilliams-UK
Copy link
Contributor Author

@tomyan112 I have created a new issue as this is nothing to do with the terminal double bond placement

@MikeWilliams-UK MikeWilliams-UK changed the title I was trying to draw norbornene and the double bond turned in to a little dot. Problem rendering norbornene Feb 11, 2020
@MikeWilliams-UK MikeWilliams-UK self-assigned this Feb 19, 2020
@MikeWilliams-UK
Copy link
Contributor Author

@tomyan112 this is how norbornene is now rendering in Word

image

@MikeWilliams-UK MikeWilliams-UK added the Fixed Fixed, but may not be released yet label Mar 5, 2020
MikeWilliams-UK added a commit that referenced this issue Mar 5, 2020
* ACME displays warning circles when valence violations occur #31
* ACME keyboard focus now returns to the editor #30
* Add ACME Option to render in Monochrome #11
* Add ACME Option to show/hide Implicit Hydrogens #17
* Fix flipping of functional groups #35
* Fix crash when using Create PDF button on Adobe Acrobat Word Add-In #40
* Correct rendering of double bond of norbornene #34
* Correct rendering of terminal double bonds #25
* Silently handle COMException in OnDocumentBeforeSave #42

Related work items: #677, #678, #681, #690, #697, #698, #700, #701
@MikeWilliams-UK
Copy link
Contributor Author

Fixed by beta-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fixed Fixed, but may not be released yet
Development

No branches or pull requests

1 participant