Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing explicit hydrogen (inconsistent design) #17

Closed
tomyan112 opened this issue Jan 10, 2020 · 10 comments
Closed

Confusing explicit hydrogen (inconsistent design) #17

tomyan112 opened this issue Jan 10, 2020 · 10 comments
Labels
Bug Something isn't working Fixed Fixed, but may not be released yet

Comments

@tomyan112
Copy link

In the editor,
image
After rendered,
image

@MikeWilliams-UK
Copy link
Contributor

@deadlyvices I think this is down to the Display / Editor not having the same flags as the renderer.

@tomyan112 can you include a screenshot of your renderer settings please?

@tomyan112
Copy link
Author

@deadlyvices I think this is down to the Display / Editor not having the same flags as the renderer.

@tomyan112 can you include a screenshot of your renderer settings please?

image

@MikeWilliams-UK
Copy link
Contributor

I asked for the renderer settings NOT ACME settings.

@MikeWilliams-UK
Copy link
Contributor

You can find the renderer settings in the Options dialogue 1st tab, then click on the cog to the right of the renderer selector

@tomyan112
Copy link
Author

tomyan112 commented Jan 10, 2020

image
I changed back to default setting, it is fine now.

@MikeWilliams-UK
Copy link
Contributor

MikeWilliams-UK commented Jan 10, 2020

Thanks.

The setting for "Show Implicit Hydrogens" needs to be implemented in ACME

@MikeWilliams-UK MikeWilliams-UK added the Bug Something isn't working label Jan 10, 2020
@Chem4Word Chem4Word deleted a comment from deadlyvices Jan 12, 2020
@Chem4Word Chem4Word deleted a comment from deadlyvices Jan 12, 2020
@MikeWilliams-UK
Copy link
Contributor

@deadlyvices do you think we should have an option to "Show all Carbon Atom" as well?
Do you feel that this is adequately covered by the setting of Exclict Display of Carbon atoms individually, thus not needed?

This was an experimental feature in the ChemDoodle Web Editors only.

This was requested by @tomyan112 today, but I can't find it in this issue????

@MikeWilliams-UK
Copy link
Contributor

@deadlyvices I have just checked and a Show All Carbon atoms is fully implemented in V3.

I, therefore, think we should implement it fully in C4W 2020 (V3.1)
This will require changes to both the OoXml renderer and ACME!

@deadlyvices
Copy link
Contributor

deadlyvices commented Jan 18, 2020 via email

@MikeWilliams-UK MikeWilliams-UK self-assigned this Jan 18, 2020
@MikeWilliams-UK MikeWilliams-UK added the Fixed Fixed, but may not be released yet label Feb 18, 2020
@MikeWilliams-UK MikeWilliams-UK removed their assignment Feb 19, 2020
MikeWilliams-UK added a commit that referenced this issue Mar 5, 2020
…groups

Implement new settings and Fix flipping of functional groups

New Options
- ShowAtomsInColour
- ShowImplicitHydrogens
- ShowAllCarbonAtoms

#11
#17

Functional Group Issues
#35

**Please be sure to try both Test Harness and Add-In**

Related work items: #677, #678, #681
MikeWilliams-UK added a commit that referenced this issue Mar 5, 2020
* ACME displays warning circles when valence violations occur #31
* ACME keyboard focus now returns to the editor #30
* Add ACME Option to render in Monochrome #11
* Add ACME Option to show/hide Implicit Hydrogens #17
* Fix flipping of functional groups #35
* Fix crash when using Create PDF button on Adobe Acrobat Word Add-In #40
* Correct rendering of double bond of norbornene #34
* Correct rendering of terminal double bonds #25
* Silently handle COMException in OnDocumentBeforeSave #42

Related work items: #677, #678, #681, #690, #697, #698, #700, #701
@MikeWilliams-UK
Copy link
Contributor

Fixed by beta-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fixed Fixed, but may not be released yet
Development

No branches or pull requests

3 participants