Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to add or remove hydrogen automatically #31

Closed
tomyan112 opened this issue Feb 8, 2020 · 9 comments
Closed

Fail to add or remove hydrogen automatically #31

tomyan112 opened this issue Feb 8, 2020 · 9 comments
Labels
Bug Something isn't working Fixed Fixed, but may not be released yet

Comments

@tomyan112
Copy link

image

https://youtu.be/VCslE7wpY_I
@MikeWilliams-UK MikeWilliams-UK added the Bug Something isn't working label Feb 8, 2020
@MikeWilliams-UK
Copy link
Contributor

@deadlyvices can you have a look at this please

@deadlyvices
Copy link
Contributor

That looks interesting. For one, that carbon at the other end of the bond is pentavalent, and that shouldn't have happened.

@MikeWilliams-UK
Copy link
Contributor

@deadlyvices they get corrected if you select all and move them, so it's a repaint issue.

@MikeWilliams-UK MikeWilliams-UK added the Fixed Fixed, but may not be released yet label Feb 12, 2020
@tomyan112
Copy link
Author

tomyan112 commented Feb 13, 2020 •
edited
Loading

That looks interesting. For one, that carbon at the other end of the bond is pentavalent, and that shouldn't have happened.

Since you said it is not suppose to be pentavalent or more, this would be interesting to you. Maybe add an optional structure check? If it is not optional, you would not be able to intentionally draw a wrong structure.
image
image

@deadlyvices
Copy link
Contributor

You can now intentionally draw a wrong structure but ACME will place a red circle over the over-bonded atoms.

@MikeWilliams-UK
Copy link
Contributor

How about a picture @deadlyvices ?

@MikeWilliams-UK
Copy link
Contributor

We allow intentional errors as Chem4Word is aimed at the educational market.

@deadlyvices
Copy link
Contributor

deadlyvices commented Feb 14, 2020 •
edited
Loading

image

It's been a useful exercise, and as a side-effect it makes the code cleaner and easier to maintain

MikeWilliams-UK added a commit that referenced this issue Mar 5, 2020
@MikeWilliams-UK
Merged PR 338: V3.1.6 Beta 6
6d3f336 
* ACME displays warning circles when valence violations occur #31
* ACME keyboard focus now returns to the editor #30
* Add ACME Option to render in Monochrome #11
* Add ACME Option to show/hide Implicit Hydrogens #17
* Fix flipping of functional groups #35
* Fix crash when using Create PDF button on Adobe Acrobat Word Add-In #40
* Correct rendering of double bond of norbornene #34
* Correct rendering of terminal double bonds #25
* Silently handle COMException in OnDocumentBeforeSave #42

Related work items: #677, #678, #681, #690, #697, #698, #700, #701
@MikeWilliams-UK
Copy link
Contributor

Fixed by beta-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Fixed Fixed, but may not be released yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomyan112 @deadlyvices @MikeWilliams-UK