Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an emission parameter to the solid color material #925

Closed
wants to merge 1 commit into from

Conversation

emackey
Copy link
Contributor

@emackey emackey commented Jul 2, 2013

Is this worth doing? Basically our default solid color can become complete black depending on lighting conditions, and this introduces an emission percentage that acts as ambient light, preserving visibility of the color.

This does add some complexity to our simplest material, and only fixes the one material. The GridMaterial has a similar fix hard-coded into it. Is there some better way to fix it for all materials?

If we do decide to accept this, we should add CZML & DynamicScene support for the new parameter before this gets merged.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 2, 2013

We are several months out from doing a nice lighting system, so we'll welcome incremental improvements in the meantime.

This could be OK, but let @bagnell investigate #924 first.

@mramato
Copy link
Contributor

mramato commented Jul 2, 2013

I think the correct answer here is that we need to fix lighting for 2D and Columbus View (#592) and find the actual cause of #924. Perhaps an ambient lighting setting in the scene would be nice, but I'm not sure we need something per material. It seems like the wrong kind of "fix" (from an API abstraction standpoint).

@emackey emackey mentioned this pull request Jul 29, 2013
@emackey
Copy link
Contributor Author

emackey commented Jul 30, 2013

Rather than adding this to the solid color material, I'm thinking now about what @mramato said above about the desire for a scene-level ambient light setting. We could add something that would affect the outcome of czm_phong and friends to prevent it getting "too dark" (per user setting). In the meantime I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants