Add an emission parameter to the solid color material #925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this worth doing? Basically our default solid color can become complete black depending on lighting conditions, and this introduces an emission percentage that acts as ambient light, preserving visibility of the color.
This does add some complexity to our simplest material, and only fixes the one material. The
GridMaterial
has a similar fix hard-coded into it. Is there some better way to fix it for all materials?If we do decide to accept this, we should add CZML & DynamicScene support for the new parameter before this gets merged.