Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3d tiles clipping planes sandcastle #6400

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Fix 3d tiles clipping planes sandcastle #6400

merged 2 commits into from
Apr 2, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Apr 2, 2018

Error when calling scene.primitives.removeAll with a mix of primitives and entities. Same problem as #6367.

@hpinkos can you review?

@cesium-concierge
Copy link

Signed CLA is on file.

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@@ -255,7 +255,6 @@

function reset() {
viewer.entities.removeAll();
viewer.scene.primitives.removeAll();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to replace this with something like viewer.scene.primitives.remove(tileset)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make that change to Terrain Clipping Planes.html too?

@hpinkos
Copy link
Contributor

hpinkos commented Apr 2, 2018

Camera.html also calls scene.primitives.removeAll for removing the DebugModelMatrixPrimitive added in the setReferenceFrame section. Change that to something like scene.primitives.remove(referenceFramePrimitive)

@lilleyse
Copy link
Contributor Author

lilleyse commented Apr 2, 2018

@hpinkos Updated

@hpinkos hpinkos merged commit 8681650 into master Apr 2, 2018
@hpinkos hpinkos deleted the sandcastle-fix branch April 2, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants