Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3d tiles clipping planes sandcastle #6400

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Fix 3d tiles clipping planes sandcastle #6400

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
975274d
Fix 3d tiles clipping plane sandcastle
lilleyse Apr 2, 2018
eed7d7a
Update other Sandastle demos
lilleyse Apr 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Apps/Sandcastle/gallery/3D Tiles Clipping Planes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@

function reset() {
viewer.entities.removeAll();
viewer.scene.primitives.removeAll();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to replace this with something like viewer.scene.primitives.remove(tileset)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make that change to Terrain Clipping Planes.html too?

planeEntities = [];
targetY = 0.0;
tileset = undefined;
Expand Down