-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymize handling workflow #3165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c02890
to
cb159dc
Compare
40c29dc
to
aee6ffc
Compare
ed707d5
to
058b342
Compare
175995d
to
eb8b77c
Compare
6d812e0
to
5251d84
Compare
5251d84
to
8e087b9
Compare
cc23fc3
to
80aef69
Compare
Macroz
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our review together looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #3130
Add new option :anonymize-handling to workflow. When enabled,
handling users
are anonymizedfor applying users
in:Anonymized user is replaced with "rems-handler" and name/email is set to nil. Other attributes are omitted.
Events contain :event/actor (userid) and :event/actor-attributes, attachments contain :attachment/user. Certain event emails to applying users contain event actor that may be a handling user.
Anonymized userid can be localized in user interface and event emails with :t.roles/anonymized-handler, which uses :t.roles/handler. For example the english default translation is "Handler", and can be safely overridden in extra translations without overriding :t.roles/handler.
Other notable changes:
[:userid :name :email]
instead of[:userid :name :email :organizations :notification-email]
1.86.1355
(originally thought something was broken with earlier version, but was actually a case of PEBKAC. however newer version did not break anything so updated anyway)Checklist for author
Remove items that aren't applicable, check items that are done.
Reviewability
Backwards compatibility
Documentation
Testing
Screenshots
Admin
Application as handler
PDF as handler
Application as applicant
PDF as applicant