Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymize handling workflow #3165

Merged
merged 27 commits into from
Oct 13, 2023
Merged

Anonymize handling workflow #3165

merged 27 commits into from
Oct 13, 2023

Conversation

aatkin
Copy link
Collaborator

@aatkin aatkin commented Jun 16, 2023

relates #3130

Add new option :anonymize-handling to workflow. When enabled, handling users are anonymized for applying users in:

  • application events and attachments
  • event emails.

Anonymized user is replaced with "rems-handler" and name/email is set to nil. Other attributes are omitted.

Events contain :event/actor (userid) and :event/actor-attributes, attachments contain :attachment/user. Certain event emails to applying users contain event actor that may be a handling user.

Anonymized userid can be localized in user interface and event emails with :t.roles/anonymized-handler, which uses :t.roles/handler. For example the english default translation is "Handler", and can be safely overridden in extra translations without overriding :t.roles/handler.

Other notable changes:

  • rems.application.model/censor-user now returns only [:userid :name :email] instead of [:userid :name :email :organizations :notification-email]
  • updated lambdaisland/kaocha to 1.86.1355 (originally thought something was broken with earlier version, but was actually a case of PEBKAC. however newer version did not break anything so updated anyway)
  • workflow type field now has label in admin page.

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Consider adding screenshots for ease of review

Backwards compatibility

  • API is backwards compatible
  • Feature appears correctly in PDF print

Documentation

  • Update changelog if necessary
  • Update manual/ (if applicable) (owner manual perhaps?) Check manual #3197

Testing

  • Complex logic is unit tested
  • Valuable features are integration / browser / acceptance tested automatically

Screenshots

Admin

Screenshot 2023-10-13 at 14 58 14

Screenshot 2023-09-19 at 23 57 07

Application as handler

Screenshot 2023-09-20 at 0 07 58

PDF as handler

Screenshot 2023-09-20 at 0 02 31

Application as applicant

Screenshot 2023-09-20 at 0 07 29

PDF as applicant

Screenshot 2023-09-20 at 0 02 10

@aatkin aatkin force-pushed the 3130/anonymous-workflow branch 2 times, most recently from 9c02890 to cb159dc Compare June 21, 2023 18:59
@aatkin aatkin force-pushed the 3130/anonymous-workflow branch 3 times, most recently from 40c29dc to aee6ffc Compare July 3, 2023 16:07
@aatkin aatkin force-pushed the 3130/anonymous-workflow branch 2 times, most recently from ed707d5 to 058b342 Compare July 13, 2023 11:13
@aatkin aatkin force-pushed the 3130/anonymous-workflow branch 2 times, most recently from 175995d to eb8b77c Compare September 8, 2023 12:00
@aatkin aatkin force-pushed the 3130/anonymous-workflow branch from 6d812e0 to 5251d84 Compare September 19, 2023 20:58
@aatkin aatkin force-pushed the 3130/anonymous-workflow branch from 5251d84 to 8e087b9 Compare September 19, 2023 21:03
@aatkin aatkin changed the title WIP 3130/anonymous workflow Anonymize handling workflow Sep 19, 2023
@aatkin aatkin marked this pull request as ready for review September 19, 2023 21:10
@aatkin aatkin requested a review from Macroz September 19, 2023 21:10
@aatkin aatkin force-pushed the 3130/anonymous-workflow branch from cc23fc3 to 80aef69 Compare September 20, 2023 13:41
Copy link
Collaborator

@Macroz Macroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our review together looks good 👍

@aatkin aatkin merged commit 3f4ebbc into master Oct 13, 2023
@aatkin aatkin deleted the 3130/anonymous-workflow branch October 13, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants