Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bob/6393 replace unarchive dropdowns with combos #6504

Merged
merged 9 commits into from
Sep 12, 2023
Merged

Bob/6393 replace unarchive dropdowns with combos #6504

merged 9 commits into from
Sep 12, 2023

Conversation

fzhao99
Copy link
Contributor

@fzhao99 fzhao99 commented Sep 8, 2023 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Replaces dropdowns with comboboxes on the unarchive patient facility page
  • Moves some of the error state warnings into UI disabled states to be more in line with the way we're handling things in ManageFacility. Updated tests accordingly.
    • If folks feel strongly that error states are preferable here to gating things behind disabled states, happy to go back and rework them.

Screenshots / Demos

deployed on dev 1.

Happy path

Screen.Recording.2023-09-11.at.3.43.41.PM.mov

Clear filters

Screen.Recording.2023-09-11.at.3.44.30.PM.mov

Clearing org select clears everything

Screen.Recording.2023-09-11.at.3.45.14.PM.mov

No facilities

Screenshot 2023-09-11 at 3 44 58 PM

@fzhao99 fzhao99 mentioned this pull request Sep 8, 2023
Merged
@fzhao99 fzhao99 force-pushed the bob/6393-replace-unarchive-dropdowns-with-combos branch 2 times, most recently from 6910519 to df57a09 Compare September 11, 2023 12:59
fzhao99
fzhao99 commented Sep 11, 2023
View reviewed changes
frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatient.test.tsx
// show form errors
await clickSearch();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the UI active / disable state is now dependent on whether the relevant ID's are defined, I deleted this check.

@fzhao99 fzhao99 force-pushed the bob/6393-replace-unarchive-dropdowns-with-combos branch from 883e673 to 2e248c0 Compare September 11, 2023 16:52
@fzhao99 fzhao99 temporarily deployed to Dev September 11, 2023 18:14 — with GitHub Actions Inactive
@fzhao99 fzhao99 temporarily deployed to Dev September 11, 2023 18:46 — with GitHub Actions Inactive
@fzhao99 fzhao99 temporarily deployed to Dev September 11, 2023 19:38 — with GitHub Actions Inactive
@fzhao99 fzhao99 marked this pull request as ready for review September 11, 2023 19:47
@fzhao99 fzhao99 requested review from mehansen, BobanL, emyl3 and johanna-skylight and removed request for johanna-skylight September 11, 2023 19:47
emyl3
emyl3 requested changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small change request! Otherwise looks good (tested on dev1, pagination, and ran through axe) -- thank you for converting all the dropdowns to something usable 🤩

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.2% 87.2% Coverage
0.0% 0.0% Duplication

@fzhao99 fzhao99 requested a review from emyl3 September 12, 2023 12:54
@fzhao99
Copy link
Contributor Author

fzhao99 commented Sep 12, 2023

ready for re-review!

BobanL
BobanL approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this :)

emyl3
emyl3 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the change!!

@fzhao99 fzhao99 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 30464f5 Sep 12, 2023
@fzhao99 fzhao99 deleted the bob/6393-replace-unarchive-dropdowns-with-combos branch September 12, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@emyl3 emyl3 emyl3 approved these changes

@mehansen mehansen Awaiting requested review from mehansen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change selects/dropdowns in support admin manage facility and unarchive patient pages
3 participants
@fzhao99 @BobanL @emyl3