Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unarchive patient functionality for support admins #6414

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Aug 24, 2023

FRONTEND PULL REQUEST

Changes Proposed

  • Adds unarchive patient functionality for support admins
  • Adds a link to the "Unarchive patient" page on the support admin landing page

Additional Information

N/A

Testing

available on dev5 for testing

Screenshots / Demos

unarchive.mov

@emyl3 emyl3 force-pushed the elisa/6064-unarchive-action branch 2 times, most recently from 59e364b to 965d5f2 Compare August 25, 2023 15:11
@emyl3 emyl3 temporarily deployed to Dev5 August 25, 2023 15:31 — with GitHub Actions Inactive
@emyl3 emyl3 force-pushed the elisa/6064-unarchive-action branch 2 times, most recently from 68e8720 to c469922 Compare August 25, 2023 20:05
@emyl3 emyl3 temporarily deployed to Dev5 August 25, 2023 20:36 — with GitHub Actions Inactive
@emyl3 emyl3 marked this pull request as ready for review August 25, 2023 20:52
@fzhao99
Copy link
Contributor

fzhao99 commented Aug 28, 2023

Code looks good overall! I found a minor bug testing in dev.

If you click fast enough into the facility dropdown after filling in the org selection, I think we might be hitting some sort of race condition for the facility selection not quite loading and causing us to get into a weird state in the form validation (notice the initial empty list on facility dropdown select that populates a second later). The result is after you fill in both of the dropdowns, you get "Org is required", even though it's selected. You can fix it just by hitting the search button again, so not too big of a deal, but flagging since it might be a bit confusing and I think the fix is pretty straightforward.

Screen.Recording.2023-08-28.at.11.00.48.AM.mov

In other places we pass a disabled prop based off the loading state of the org fetch.. I think if we do something similar here we can fix it.

@emyl3
Copy link
Collaborator Author

emyl3 commented Aug 28, 2023

Code looks good overall! I found a minor bug testing in dev.

If you click fast enough into the facility dropdown after filling in the org selection, I think we might be hitting some sort of race condition for the facility selection not quite loading and causing us to get into a weird state in the form validation (notice the initial empty list on facility dropdown select that populates a second later). The result is after you fill in both of the dropdowns, you get "Org is required", even though it's selected. You can fix it just by hitting the search button again, so not too big of a deal, but flagging since it might be a bit confusing and I think the fix is pretty straightforward.

Screen.Recording.2023-08-28.at.11.00.48.AM.mov
In other places we pass a disabled prop based off the loading state of the org fetch.. I think if we do something similar here we can fix it.

OOO thank you for catching this -- will fix this!

@emyl3 emyl3 force-pushed the elisa/6064-unarchive-action branch from c469922 to 92faa87 Compare August 28, 2023 16:51
@emyl3 emyl3 temporarily deployed to Dev5 August 28, 2023 17:16 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.1% 82.1% Coverage
0.0% 0.0% Duplication

@emyl3
Copy link
Collaborator Author

emyl3 commented Aug 28, 2023

@fzhao99 ready for re-review!

Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@emyl3
Copy link
Collaborator Author

emyl3 commented Aug 28, 2023

Thanks everyone! Will wait to hear back from @jayna-SkylightDigital before merging in. Leaving this as a note for myself so I don't accidentally merge it until the support team's approval 😅

@emyl3 emyl3 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 23bcefa Aug 29, 2023
@emyl3 emyl3 deleted the elisa/6064-unarchive-action branch August 29, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unarchive patient] Unarchive action
4 participants