-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unarchive patient functionality for support admins #6414
Conversation
59e364b
to
965d5f2
Compare
68e8720
to
c469922
Compare
Code looks good overall! I found a minor bug testing in dev. If you click fast enough into the facility dropdown after filling in the org selection, I think we might be hitting some sort of race condition for the facility selection not quite loading and causing us to get into a weird state in the form validation (notice the initial empty list on facility dropdown select that populates a second later). The result is after you fill in both of the dropdowns, you get "Org is required", even though it's selected. You can fix it just by hitting the search button again, so not too big of a deal, but flagging since it might be a bit confusing and I think the fix is pretty straightforward. Screen.Recording.2023-08-28.at.11.00.48.AM.movIn other places we pass a disabled prop based off the loading state of the org fetch.. I think if we do something similar here we can fix it. |
OOO thank you for catching this -- will fix this! |
c469922
to
92faa87
Compare
Kudos, SonarCloud Quality Gate passed! |
@fzhao99 ready for re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Thanks everyone! Will wait to hear back from @jayna-SkylightDigital before merging in. Leaving this as a note for myself so I don't accidentally merge it until the support team's approval 😅 |
FRONTEND PULL REQUEST
Changes Proposed
Additional Information
N/A
Testing
available on dev5 for testing
Screenshots / Demos
unarchive.mov