-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile resx file into binary resource file for use in AssemblyAction #98
Compile resx file into binary resource file for use in AssemblyAction #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just cursory nits. Haven't dug into implementation too much yet.
Co-Authored-By: Jacob Parker <[email protected]>
I have simplified the work done down to two rules, and moved the C++ compilation wrapper into the bash wrapper. This wrapper doesn't have as much going on (besides the boilerplate runfiles code). I did discover something while working on windows, and that is that there exists a segmentation fault in the |
Sorry in the delay getting back to this, I'll go through it on the weekend when I have some quiet time :) |
The latest version has requirements the existence of project.assets.json
While doing the housekeeping on some of these PRs, I noticed that with the latest release of the dotnet SDK That was failing the resx compilation due to its usage of |
:( |
Compiles a single resx file into a common language runtime binary resource file.
Example usage:
There a couple of things I'll mention here:
Resolves #10 , #77