Wrap the dotnet executable to set default environment variables #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j3parker
reviewed
Nov 22, 2019
j3parker
reviewed
Nov 22, 2019
j3parker
reviewed
Nov 22, 2019
j3parker
reviewed
Nov 22, 2019
j3parker
reviewed
Nov 22, 2019
Co-Authored-By: Jacob Parker <[email protected]>
…es_csharp into dotnet/wrap-the-dotnet-exe
added 2 commits
November 26, 2019 16:52
This reverts commit 80e56d3.
j3parker
reviewed
Nov 27, 2019
j3parker
reviewed
Nov 27, 2019
j3parker
reviewed
Nov 27, 2019
j3parker
reviewed
Nov 27, 2019
j3parker
reviewed
Nov 27, 2019
j3parker
reviewed
Nov 27, 2019
|
Were you able to do your testing on Mac? |
|
Yes, for commit 8d0ef05 I changed to list initialization and enforced Seems that the MacOS version of |
j3parker
reviewed
Dec 2, 2019
| default = Label(_TEMPLATE), | ||
| allow_single_file = True | ||
| ), | ||
| "src": attr.label_list( |
There was a problem hiding this comment.
nit: this file isn't really used at compile time so it's a tiny bit weird to call it src, but that's fine. This is an internal rule.
j3parker
reviewed
Dec 2, 2019
|
|
||
| /* | ||
| dotnet requires these environment variables to be set. | ||
| */ |
There was a problem hiding this comment.
nit: inconsistent comment style in this file
j3parker
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #98 I encountered difficulty while trying to run the
dotnet.execross-platform. It has the requirement that the environment variablesHOME, DOTNET_CLI_HOME, APPDATA, PROGRAMFILESare defined.Although constants could works (conditional by OS), this means that properties of a bazel dir could impact how a build compiles. Instead, this PR creates a wrapper
dotnetwthat sets environment variables before execution.This is a draft at the moment while I iron about some edge cases (and refactor the wrapper)
Related to #10