WIP: Single resx compilation using dotnet cli for compilation #96
Conversation
| print("todo") | ||
|
|
||
| csharp_resx = rule( | ||
| implementation = _csharp_resx_impl, |
There was a problem hiding this comment.
I'm thinking we'll want to provide a custom struct as mentioned in #77, as the name of the output .resources file is determined by either the csproj file name or the RootNamespace property. We could add an out property for modifying the name of the csproj file (rather than relying solely on identifier) (more on PR #93)
There was a problem hiding this comment.
The struct sounds good. I think the fact that we're generating a csproj behind the scenes is an implementation detail that we wouldn't want to expose via attrs though?
There was a problem hiding this comment.
The struct containing a identifier property (or out for controlling output name) is not really related to the csproj, but to how the resources are consumed by C# compiler:
-resource:filename[,identifier[,accessibility-modifier]]
With parameters like that, I can pass in a resources file named hello.look.at.this.name.resources, but use the identifier hello.Strings.resources. This is what I was getting at in this discussion
| csharp_resx = rule( | ||
| implementation = _csharp_resx_impl, | ||
| attrs = { | ||
| "src": attr.label( |
There was a problem hiding this comment.
It might be more ergonomic for this to be srcs and to invoke dotnet multiple times in a loop behind the scenes.
There was a problem hiding this comment.
If we went this route, the API for specifying the identifier would need to be a label_keyed_string_dict, which makes the specification of the identifier mandatory.
I would also have concerns with the resource being used incorrectly with localized resx files. For localized resx files, satellite assemblies are created in directories based on the culture code. Those will need some special handling, as the pathing of those assemblies matter.
| default = Label(_TEMPLATE), | ||
| allow_single_file = True, | ||
| ), | ||
| "_dotnet_runner": attr.string( |
There was a problem hiding this comment.
I think this should use toolchains instead. Check out how the csharp_library etc. rules get access to dotnet.exe
| deps = ["@net//:System.Linq"], | ||
| ) | ||
|
|
||
| csharp_resx( |
There was a problem hiding this comment.
Looks good. If src -> srcs then it'd be idiomatic to name this rule csharp_resx_library.
|
Some of the errors in CI are about adding the symbol to https://github.com/Brightspace/rules_csharp/blob/master/csharp/defs.bzl |
| mandatory = True, | ||
| allow_single_file = True | ||
| ), | ||
| "identifier": attr.string( |
There was a problem hiding this comment.
I've been looking into an out parameter to specify the name of the compiled resource. With EmbeddedResource's you can specify the property LogicalName that is used by GenerateResource to set the output name.
The GenerateResource task uses the metadata of an item to name the resource that is embedded in an assembly.
Assuming that the assembly is named myAssembly, the following code generates an embedded resource named someQualifier.someResource.resources:
Based on my testing so far I haven't been successful with getting the compiled resource named based on the LogicalName property. I'll try testing this from visual studio, to get a better idea of how this is happening in that environment.
|
Closing draft as working copy is now raised at #98. |
An API for compiling a single resx into a
.resourcesbinary.Related to #10