CMake: Fix PThread Flag #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On recent manylinux builds for ppc64le, I realized problems with ``` undefined reference to `pthread_atfork' ``` at linktime. The reason for that is likely an outdated CMake flag that would request the right pthread flags. Old: `CMAKE_THREAD_PREFER_PTHREAD` ([docs](https://cmake.org/cmake/help/v3.2/module/FindThreads.html)) New: `THREADS_PREFER_PTHREAD_FLAG` ([docs](https://cmake.org/cmake/help/latest/module/FindThreads.html))
1 task
|
We should maybe also use the new |
kalvdans
approved these changes
Jun 16, 2021
This comment has been minimized.
This comment has been minimized.
This target does potentially contain CXX flags and linker flags and shoulds thus be preferred. It should also address the already work-arounded pthread linker issue in one of the tests.
|
That looks good to me. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed Issue
On recent manylinux builds for ppc64le, I realized problems with
at linktime when propagating a static blosc library to downstream libraries (all via CMake).
Fix: CMake Control Variable
An outdated CMake flag that would request the right pthread flags is used:
Old:
CMAKE_THREAD_PREFER_PTHREAD(docs)New:
THREADS_PREFER_PTHREAD_FLAG(docs)Fix: CMake Thread Target
Prefer
Threads::Threadsfor CMake 3.1+: This target does potentially contain CXX flags and linker flags and should thus be preferred.It should also address the already work-arounded pthread linker issue in one of the tests that @jack-pappas added in #123
To Do