Hidden symbols fix #123
Merged
Hidden symbols fix #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved preprocessor ifdefs which define the symbol indicating an exported symbol into a common file (blosc-export.h) that handles both blosc and the shuffle implementations. For testing, build a special version of the blosc shared library which exports some normally-hidden symbols; the test binaries now link to this version of the library so they can test internal library functions.
|
I have had a look at the new visible symbols (basically, the ones listed in blosc.h) and I think they are all in. So merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the symbol hiding introduced in #112 and should allow #114 to be re-submitted without breaking the build.
When
BUILD_TESTSis enabled in the CMake configuration, we now build a second, special version oflibblosc/blosc.dllthat exposes the normally-hidden symbols likeshuffle_sse2to allow the tests to call them directly without going through the CPU feature-detection code. This extra library is calledlibblosc_testing/blosc_testing.dlland is not installed like the other libraries -- it is only used by and for the tests.One thing that should be checked before accepting this PR -- the CMake config script now sets the symbol visibility to hidden by default (e.g., it will pass
-fvisibility=hiddento GCC and Clang), so this might end up hiding some additional symbols that were visible by default before. If that's the case and they still need to be exported (for backwards compatibility), please let me know so I can make the necessary adjustments to preserve their visibility.