Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheels: 0.13.4.post1 #1013

Merged
merged 6 commits into from
Jun 17, 2021
Merged

Wheels: 0.13.4.post1 #1013

merged 6 commits into from
Jun 17, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jun 16, 2021

Try to mitigate import error of

undefined reference to `pthread_atfork'

on PPC64le.

I think this line in blosc is outdated:
https://github.com/Blosc/c-blosc/blob/7435f28dd08606bd51ab42b49b0e654547becac4/blosc/CMakeLists.txt#L68
Is: CMAKE_THREAD_PREFER_PTHREAD (docs)
Should be: THREADS_PREFER_PTHREAD_FLAG (docs)

See:
#1002 (comment)

Upstream: Blosc/c-blosc#318

In the end, we fixed it due to an error in FindBlosc.cmake in ADIOS2: ornladios/ADIOS2#2768

To Do

  • bump version (via patch)

@ax3l ax3l added bug affects latest release machine/system machine & HPC system specific issues continuous deployment automated shipping labels Jun 16, 2021
@ax3l ax3l mentioned this pull request Jun 16, 2021
@ax3l ax3l requested a review from franzpoeschel June 16, 2021 19:42
library_builders.sh Outdated Show resolved Hide resolved
library_builders.sh Outdated Show resolved Hide resolved
@ax3l ax3l force-pushed the topic-bloscPreferPthread branch from 7140371 to 5d52fbd Compare June 16, 2021 21:06
@ax3l ax3l force-pushed the topic-bloscPreferPthread branch from 0c5956f to e43141d Compare June 16, 2021 21:44
The self-written find-module does not search for pthreads yet.
ornladios/ADIOS2#2768
@ax3l ax3l force-pushed the topic-bloscPreferPthread branch from 24e42b8 to 0063880 Compare June 17, 2021 02:37
Fix the FindBlosc.cmake logic to search properly for
threads.
@ax3l ax3l force-pushed the topic-bloscPreferPthread branch from de3b79a to 7491ab5 Compare June 17, 2021 02:54
@ax3l ax3l changed the title Wheels: Blosc Pthread Wheels: 0.13.4.post1 Jun 17, 2021
@ax3l ax3l merged commit c8aa31e into openPMD:wheels Jun 17, 2021
@ax3l ax3l deleted the topic-bloscPreferPthread branch June 17, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects latest release bug continuous deployment automated shipping machine/system machine & HPC system specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant