-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent CI failures with python 3.x/3.12
due to ForwardRef
#3346
Comments
it seems rerunning the test worked? I'm going to leave this issue open since this doesn't seem like a one off kinda problem |
I'm working on eliminating the https://stackoverflow.com/questions/39740632/python-type-hinting-without-cyclic-imports |
3.x
3.x/3.12
due to ForwardRef
3.x/3.12
due to ForwardRef
3.x/3.12
due to ForwardRef
* pin python<3.12.4 * disable 3.12 and 3.x for the time being --------- Co-authored-by: Tess Hayes <[email protected]>
Testing locally this seems to only be breaking for python |
This PR (closes Bears-R-Us#3049) removes the upper bound of our `mypy` version since the latest works just fine. Also related to Bears-R-Us#3346, I changed the python restriction to be `!=3.12.4` since `3.12.3` works just fine. It seems version `3.12.5` was just released, so we'll have to see if the forward refs are still an issue
This PR (closes Bears-R-Us#3049) removes the upper bound of our `mypy` version since the latest works just fine. Also related to Bears-R-Us#3346, I changed the python restriction to be `!=3.12.4` since `3.12.3` works just fine. It seems version `3.12.5` was just released, so we'll have to see if the forward refs are still an issue
This PR (closes #3049) removes the upper bound of our `mypy` version since the latest works just fine. Also related to #3346, I changed the python restriction to be `!=3.12.4` since `3.12.3` works just fine. It seems version `3.12.5` was just released, so we'll have to see if the forward refs are still an issue Co-authored-by: Tess Hayes <[email protected]>
python 3.12.5 was released 2 days ago https://www.python.org/downloads/release/python-3125/ It seems to make some changes to how they handle I'm hoping this will fix the problems we were having. It's not yet available through conda, but I'm impatient so I'm going to build from source edit: |
okay that didn't fix our problem, but I did find this: indicating we needed to switch from TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard' This one is seen by others when moving from 3.12.3 to 3.12.4, so I feel like we're on the right track. It seems most other ppl are using pydantic so this was an upstream error for them |
This PR (Closes Bears-R-Us#3703) makes `3.12.3` the upper bound for python version because greater than this causes `ForwardRef` type errors. These will be worked in Bears-R-Us#3346. I also added a single dim registration file to `.configs` to make switching between states easier
This PR (Closes #3703) makes `3.12.3` the upper bound for python version because greater than this causes `ForwardRef` type errors. These will be worked in #3346. I also added a single dim registration file to `.configs` to make switching between states easier Co-authored-by: Tess Hayes <[email protected]>
Even after pinning the numpy version to
<2.0
I'm still seeing CI failures:https://github.com/Bears-R-Us/arkouda/actions/runs/9572308279/attempts/1It seems only the
3.x
python version is affected. The python version was3.12.4
with an error along the lines ofSo this appears to be a forward ref issue
The interesting bit is that python 3.12.0 didn't have this issue and python
3.12.4
was released on June 6th but we've had successful runs since then...I think the most straightforward plan is to pin the python version as well until we can dig into it more
The text was updated successfully, but these errors were encountered: