Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementally update code to handle new type checking versions #3645

Open
stress-tess opened this issue Aug 9, 2024 · 1 comment
Open

Incrementally update code to handle new type checking versions #3645

stress-tess opened this issue Aug 9, 2024 · 1 comment

Comments

@stress-tess
Copy link
Member

stress-tess commented Aug 9, 2024

While working on PR #3638. I went through in and resolved most of the mypy issues, but I realized this would result in a massive PR since it would be making a lot of updates to satisfy mypy once typeguard is upgraded

If possible it would definitely be better to go through the files one by one and get them to the point where mypy is satisfied, so we can get more thorough reviews. We can then make the typeguard upgrade and re-enable the python 3.12 and 3.x workflows without needing a massive PR

This is a prerequisite for #3346

@stress-tess stress-tess self-assigned this Aug 9, 2024
@stress-tess
Copy link
Member Author

It does seem like typeguard has changed the functionality of it's check_type, so we may need to wrap it in order to be backwards compatible with out previous pinned version of mypy and I'd rather not require everyone jump ahead multiple versions

@stress-tess stress-tess removed their assignment Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant