Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported mypy versions #3049

Closed
stress-tess opened this issue Mar 19, 2024 · 0 comments · Fixed by #3635
Closed

Update supported mypy versions #3049

stress-tess opened this issue Mar 19, 2024 · 0 comments · Fixed by #3635
Labels
Dependency Update Add dependency or update code based on changes to dependencies.

Comments

@stress-tess
Copy link
Member

We are seeing failures with mypy versions in the supported range specifically 0.982 when the range is mypy>=0.931,<0.990

We should :

  • figure out what the new minimum supported mypy version is
  • go through and address the mypy errors so we can remove the upper limit
@stress-tess stress-tess added the Dependency Update Add dependency or update code based on changes to dependencies. label Mar 19, 2024
stress-tess added a commit to stress-tess/arkouda that referenced this issue Aug 7, 2024
@stress-tess
Closes Bears-R-Us#3049: upin mypy version
0116970 
This PR (closes Bears-R-Us#3049) removes the upper bound of our `mypy` version since the latest works just fine. Also related to Bears-R-Us#3346, I changed the python restriction to be `!=3.12.4` since `3.12.3` works just fine. It seems version `3.12.5` was just released, so we'll have to see if the forward refs are still an issue
@stress-tess stress-tess mentioned this issue Aug 7, 2024
Merged
stress-tess added a commit to stress-tess/arkouda that referenced this issue Aug 7, 2024
@stress-tess
Closes Bears-R-Us#3049: upin mypy version
4085aee 
This PR (closes Bears-R-Us#3049) removes the upper bound of our `mypy` version since the latest works just fine. Also related to Bears-R-Us#3346, I changed the python restriction to be `!=3.12.4` since `3.12.3` works just fine. It seems version `3.12.5` was just released, so we'll have to see if the forward refs are still an issue
github-merge-queue bot pushed a commit that referenced this issue Aug 8, 2024
@stress-tess
Closes #3049: upin mypy version (#3635)
63a9d3e 
This PR (closes #3049) removes the upper bound of our `mypy` version since the latest works just fine. Also related to #3346, I changed the python restriction to be `!=3.12.4` since `3.12.3` works just fine. It seems version `3.12.5` was just released, so we'll have to see if the forward refs are still an issue

Co-authored-by: Tess Hayes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dependency Update Add dependency or update code based on changes to dependencies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #3049: Remove mypy version upper bound stress-tess/arkouda
1 participant
@stress-tess