Simplify and speed up InterruptionEventLoop #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8680
added
enhancement
|
@eb8680 , this was tagged "status: awaiting review", but it looks there have been updates since that tag was assigned. Are those updates now complete? |
SamWitty
approved these changes
Nov 14, 2023
This was referenced Nov 14, 2023
rfl-urbaniak
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Add shallow handler * tests * almost works * nit * type nits * lint * nit * fix test and move base interruption to internals * fix remaining failing test * simplify torchdiffeq event fn * heapq * heapq works * move prioritized to utils * move prioritized to utils * inf * refactoring simulate_to_interruption * consolidate simulate_to_interruption * lint * move method * make all internal ops into pyro ops * simplify internal * removing get_solver * error message * mark simulate final * remove vestigial get_solver * pop solver * format * force kwargs update * add fast path for static interruption * add assertion to rule out edge case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #360Part of addressing performance and design issues from #354 #360