Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shallow effect handler base class #360

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Add shallow effect handler base class #360

merged 2 commits into from
Oct 25, 2023

Conversation

eb8680
Copy link
Contributor

@eb8680 eb8680 commented Oct 25, 2023

Part of addressing performance and design issues related to #354 #160

This PR adds an abstract "shallow" effect handler class ShallowMessenger to chirho.dynamical.internals._utils that exits after handling a single operation call. In a followup PR, I will use ShallowMessenger as a base class for chirho.dynamical.handlers.interruption.Interruption.

@eb8680 eb8680 added enhancement New feature or request status:awaiting review Awaiting response from reviewer refactor labels Oct 25, 2023
@eb8680 eb8680 added this to the ASKEM November 2023 hackathon milestone Oct 25, 2023
@eb8680 eb8680 requested a review from SamWitty October 25, 2023 02:19
Copy link
Collaborator

@SamWitty SamWitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SamWitty SamWitty merged commit f44731d into master Oct 25, 2023
@SamWitty SamWitty deleted the eb-shallow-handler branch October 25, 2023 13:39
rfl-urbaniak pushed a commit that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module:dynamical refactor status:awaiting review Awaiting response from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants