Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InterruptionEventLoop and other refactorings... #354

Closed
wants to merge 9 commits into from

Conversation

SamWitty
Copy link
Collaborator

This larger draft PR is intended to facilitate discussion about the ongoing design efforts for the dynamical module. Once we reach a consensus around this next phase of design, this will be broken up into substantially smaller PRs.

@SamWitty SamWitty added refactor discussion status:WIP Work-in-progress not yet ready for review labels Oct 19, 2023
@SamWitty SamWitty self-assigned this Oct 19, 2023
@SamWitty
Copy link
Collaborator Author

@eb8680 , is this entirely subsumed by #361 and #356 ?

@eb8680
Copy link
Contributor

eb8680 commented Nov 14, 2023

is this entirely subsumed by #361 and #356 ?

Those PRs subsume most of the internal changes to internals and handlers, but this PR also contains some changes to the public API (notably the removal of InterruptionEventLoop) that I think are still worth doing. We should create separate issues to track those, though, since the implementation of those changes here will be made obsolete by #361.

@eb8680
Copy link
Contributor

eb8680 commented Nov 14, 2023

Closing in favor of #361 and follow-up PRs

@eb8680 eb8680 closed this Nov 14, 2023
@eb8680 eb8680 deleted the sw-remove-IEL branch November 14, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion module:dynamical refactor status:WIP Work-in-progress not yet ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants