-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Uncaught Exception in NullEngine.dispose #13406
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Hmmmn, I cannot edit labels, but anyway I'm not sure that such a minor change is worth being mentioned in the ChangeLog. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13406/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13406/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13406/merge#BCU1XR#0 |
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
LGTM, but let s wait on @RaananW feedback. Could you fix the formatting and linting ? I guess it is the only missing part to merge it |
@barroij would be great if you can fix lint and format ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just formatting
@RaananW formatting done! |
I am having an uncaught exception when using BaylonJs in a NodeJs environment because of a call to
window.removeEventListener
from NullEngine.dispose().This PR adds extra checks to make that
addEventListener
/removeEventListener
do exist and are functions before calling them.This PR comes along with #13401 in order to improve BabylonJs usability in non-browser environment