Prevent Uncaught Exception from ThinEngine.runRenderLoop when window.SetTimeout in not defined

[barroij]

I am having an uncaught exception when using BaylonJs in a NodeJs environment because of a call to window.setTimeout.

It is not very clear in the code what is the standard, as sometime we call the global setTimeout and sometime we call window.setTimeout.

My take on this is that it should be ok to always call the globals setTimeout/ clearTimeout as they are bound to be defined and are the very same functions as window.setTimeout/ window.clearTimeout in most cases.

Though this PR do not change them all. I just make some 2 files more consistent where we used to use a mix of both, and I updated the ThinEngine.QueueNewFrame to NOT call window.setTimeout, but to fall back on the global setTimeout.

To really be "environment independant", we should never call a function that is "environment dependant" directly, and put them all behind a configurable callback registry. This registry would be initialized with default values, and could be customizes by the user depending on its needs. But I'm not sure how it is doable, and anyway that's another story :)

[RaananW]

LGTM! I am not sure why you opted in to use window.clearTimeout instead of removing all window references in one place, but otherwise - this is a great change.

[RaananW]

And another possible change would be to use ReturnType<setTimeout> instead of casting to unknown and then to number, but that might collide with our internal type definitions in the engine. If that the case - leave it this way

[barroij]

And another possible change would be to use ReturnType<setTimeout> instead of casting to unknown and then to number, but that might collide with our internal type definitions in the engine. If that the case - leave it this way

Well the difficulty here is that actually setTimeout is used as a fallback in case requestAnimationFrame/requestPostAnimationFrame is not defined. So the return type of QueueNewFrame should the same as requestAnimationFrame, requestPostAnimationFrame and setTimeout...

[RaananW]

let's leave it this way then.

[sebavan]

@bghgary could you check it would be ok with Native ???

[sebavan]

@barroij would be great if you can fix lint and format ?

[barroij]

@sebavan formatting done !

[RaananW]

I'll wait for @bghgary before merging just to be sure.

[bghgary]

Weird, I thought I replied, but maybe I forgot to actually send. :)

Anyways, in native, we put the setTimeout/clearTimeout functions on both window and global, so it should work either way.