Additional WebXR image tracking changes for native integration #12176
Conversation
…k since this is already gated on getImageTrackingResults and getTrackedImageScores, and change way we read in getImageTrackingResults to reduce native marshalling.
# Conflicts: # src/Engines/engine.ts # src/Engines/nativeEngine.ts # src/XR/features/WebXRImageTracking.ts # src/XR/native/nativeXRFrame.ts
Alex-MSFT
changed the title
|
We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12176/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12176/merge#BCU1XR#0 |
# Conflicts: # packages/dev/core/src/XR/features/WebXRImageTracking.ts
|
We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes. |
|
We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12176/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12176/merge#BCU1XR#0 |
|
We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12176/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12176/merge#BCU1XR#0 |
|
Is this ready to be merged now? |
I believe so, as long as you are okay with taking out the IsCompatible check for turning this feature on. Basically the only cost there is we will load the image for cases where it might not be necessary. |
|
@Alex-MSFT Just double checking, we don't need to update the protocol version for this right? |
No we should not need to, this change should be forwards compatible with the current BabylonNative without any changes. |
|
Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12176/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12176/merge#BCU1XR#0 |
This PR includes some more changes for WebXR Image Tracking integration for BabylonNative. and some cleanup from the previous change: #12097
The primary change is to update nativeXRFrame to pull the results array directly from the frame object rather than marshalling back to native code every time. This should improve per-frame CPU load.
See: BabylonJS/BabylonNative#1032 for the consuming BabylonNative change.