WebXRImageTracking and NativeEngine changes to support image tracking in BabylonNative #12097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loading and tracking in BabylonNative
RaananW
approved these changes
Mar 7, 2022
bghgary
pushed a commit
that referenced
this pull request
Apr 11, 2022
This PR includes some more changes for WebXR Image Tracking integration for BabylonNative and some cleanup from the previous change: #12097 The primary change is to update nativeXRFrame to pull the results array directly from the frame object rather than marshalling back to native code every time. This should improve per-frame CPU load. See: BabylonJS/BabylonNative#1032 for the consuming BabylonNative change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to update the implementation for WebXRImageTracking to allow for support in BabylonNative. Because we don't have access to the standard DOM HTMLImageElement type in Babylon Native, I am creating a new helper function to create image bitmaps from a provided source value, and polyfilling that in the case of a native engine to use the native Canvas Image implementation.
I'm also changing the ordering for the score check and moving it to the XR Frame loop, as we can only start image tracking after the first frame of the XR session.
The matching BabylonNative changes are being reviewed here: https://github.com/BabylonJS/BabylonNative/pull/1021/files
Primary issue: BabylonJS/BabylonNative#987