This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Inline link color should be ebon #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr3
approved these changes
Jul 3, 2019
|
Currently live Wrong styling on latest Right styling with this PR |
|
LGTM |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves N/A
UX spotted that the default link
colorshould beebonnotpostbox. Follows up #707Overall change: Changes the default inline link text color to be
ebonCode changes:
Changes the default inline link text color to be
ebonTesting notes
Checkout branch, run storybook, in an incognito window check that the
inline linkstory has textcolorofEbon#222222