This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
oluoluoxenfree
approved these changes
Jun 27, 2019
Going to move this back to "PR in progress" and update the paragraph and caption stories to give a realistically storybook example of the inline link |
3 tasks
This was referenced Jun 27, 2019
This was referenced Jul 1, 2019
RayNjeri
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out in high contrast mode. Everything seems to be work as expected.
LGTM!
j-pendlebury
approved these changes
Jul 2, 2019
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #397
Resolves #716
Overall change: Adds the new UX inline link styling which is a background colour on hover. Also maintains the border changing from 1px to 2px on hover for users in high constrast modes.
Code changes:
pre-wrap
so that for links that wrap to new lines the letter on the end of the line has a slight background bufferTesting notes:
This is most easily tested by following the instructions on #719 and then testing as described in the notes below. Happy to pair with test on this work.