Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for release v3.14.0.0 #680

Merged
merged 45 commits into from
Dec 31, 2024
Merged

Preparation for release v3.14.0.0 #680

merged 45 commits into from
Dec 31, 2024

Conversation

hdamecharla
Copy link
Member

Problem

This pull request includes multiple changes across various configuration and workflow files, primarily focusing on adding new workflows, updating dependencies, and improving code consistency.

New changes

  • Add support for HANA active/read-enabled system replication in Pacemaker cluster. A second front-end is added to the HDB load balancer with a separate health probe and load balancer rule. It re-uses the same back-end. HANA replication is set-up with the operation mode logreplay_readaccess and pacemaker is configured with an additional resource g_secip_.
  • bug fix for ensuring sapadm user is created correctly.
  • Modify the terraform and ansible code to support the addition of the SAPHanaSR-angi resource agent. Terraform tfvars variables use_sles_saphanasr_angi and ansible variable use_hanasr_angi are added to enable the resource agent.
  • Add the option to specify *_flow_timeout_in_minutes for management and workload zone VNETs, defaults to null.
  • Add the option to specify network_enable_route_propagation for subnet route tables, defaults to true.
  • Add two node cluster properties for DB2 on RHEL8, by implementing resource priority and set a fence delay of 15s.
  • Simplify and improves the readability and maintainability of the deployment pipelines by replacing inline bash scripts with external files, adding helper functions, updating environment variable names, and enhancing error handling.
  • Ensured that upgrading from older deployments work seamlessly. To support storage accounts without access keys update the scripts to remove the affected resources from the state file and reimporting to update the schema. The variable data_plane_available, controls how the storage account is accessed. When set to false, the storage account is accessed using the control plane.
  • Changed enqueue replication keepalive parameter to uppercase, setting the priority for primary IPaddr2 and azure-lb resources when priority-fencing-delay is configured, and resetting failcounts on resources using crm resource clear, immediately after configuring the resources.
  • Update ANSIBLE_COLLECTIONS_PATH variable in multiple YAML files for consistency.
  • Adjust retry logic and delays in Ansible playbooks for improved reliability.
  • Update key vault commands to use lowercase vault names and remove VC++ 2013 component.
  • Update iSCSI configuration tasks in the Ansible role for generic pacemaker. The changes focus on improving the clarity, and debugging capabilities of the iSCSI configuration process.
  • Rename agent_network_id to additional_network_id and update related references.
  • Add IPTags support.
  • provide ability to specify the random the characters that will be appended to the resource names, using the custom_random_id tfvars variable.
  • Parameter and Logging Enhancements: Added FORCE_RESET parameter and enhanced debug logging in control plane deployment pipeline. Also, added warning logs for forced re-install in control plane preparation script.
  • Script Improvements: Refactored various scripts for consistency, readability, and error handling. This includes adding shebangs, fixing typos, and improving output formatting.
  • Key Vault and Terraform Updates: Updated Key Vault configurations, enhanced logging for remote Terraform state management, and added dependencies for proper sequencing and resource creation.
  • Resource Management: Removed unnecessary dependencies and variables, such as DEPLOYER_RANDOM_ID and LIBRARY_RANDOM_ID, and improved handling of custom random IDs.
  • Error Handling and Output Management: Improved error handling and output management across multiple scripts, ensuring proper return value assignments and clear messaging for Terraform commands.

New GitHub Actions Workflows

  • Added a new dependabot.yml configuration to automate dependency updates for GitHub Actions, NuGet, and npm.
  • Introduced a codeql.yml workflow for CodeQL analysis to detect vulnerabilities in C#, JavaScript, and Python code.
  • Added a dependency-review.yml workflow to scan dependency manifest files for known vulnerabilities in pull requests.
  • Updated the ossf-scorecard.yml workflow to include the harden-runner step and updated several action versions.
  • Added a trivy.yml workflow for running Trivy vulnerability scans on pull requests.

Updates to Existing Workflows

  • Updated actions used in the steps to newer versions and added a step to harden the runner.

Other Changes

  • Added pre-commit hooks for various tools including gitleaks, shellcheck, eslint, and pylint.
  • Added copyright and license information.
  • Refactored code for better readability and consistency, including namespace changes and simplified list initialization.

KimForss and others added 30 commits October 31, 2024 13:48
@KimForss @hdamecharla
Bring in HotFix repairs (#651)
80eaec1 
* Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation

* Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership

* Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership

* Refactor deploy control plane script to include azurerm_role_assignment for deployer and storage_sapbits_contributor

* Refactor deploy control plane script to remove unnecessary Terraform installation and Azure CLI installation

* Refactor deploy control plane script to include sourcing deploy_server.sh and fixing Terraform ownership

* Refactor deploy control plane script to include dynamic role assignment based on VM count

* Refactor deploy scripts to simplify checkIfCloudShell function

* Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication

* Refactor deploy scripts to include sourcing deploy_server.sh and fixing Terraform ownership

* Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication

* Refactor deploy control plane script to include dynamic role assignment based on VM count and use managed service identity (MSI) for authentication

* handle the realfilepath and the scriptdir variables as they might be replaced with other values in child scripts

* Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication

* Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication

* Refactor deploy_utils.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication

* Refactor deploy_controlplane.sh to remove ARM_USE_MSI variable and use managed service identity (MSI) for authentication

* Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication

* Refactor installer.sh to include terraform output command

* Refactor installer.sh to comment out unnecessary terraform output command

* Refactor variables_local.tf to use client_id instead of id for service principal object_id

* Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication and remove unnecessary ARM_USE_MSI variable

* Refactor deploy_controlplane.sh to use managed service identity (MSI) for authentication

* chore: include OpenSSF Scorecard badge

* Refactor variables_local.tf to use client_id instead of id for service principal object_id
Refactor installer.sh to comment out unnecessary terraform output command

* Refactor pipeline script to use correct variable for workload ARM subscription ID

* Refactor pipeline script to use correct variable for workload ARM subscription ID

* Refactor pipeline script to include ARM_OBJECT_ID variable

* Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID

* Refactor pipeline script to use correct variable for workload ARM_CLIENT_ID

* check terraform when running in cloudshell

* Refactor pipeline script to include missing variable checks

* Refactor pipeline script to remove unnecessary variable checks

* Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script to include missing variable checks

* Refactor pipeline script to update echo statements for installation method

* Refactor pipeline script to update echo statements for installation method

* Refactor pipeline script to use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script to update echo statements for installation method

* Refactor pipeline script to update echo statements for installation method

* Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script

* Refactor pipeline script to update echo statements for installation method and use correct variables for workload ARM_CLIENT_ID

* Refactor pipeline script to update echo statements and export variables for installation method and workload ARM_CLIENT_ID

* Refactor pipeline script to update PATH variable in deploy_controlplane.sh

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update echo statement for displaying the key vault information

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update usage of Azure CLI command in installer.sh

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor provider configuration to use Azure Key Vault for subscription ID retrieval

* Fixes #1: Added a new line to the installer script

* Refactor pipeline script to fix unzip command in deploy control plane stage

* Refactor pipeline script to update echo statements and export variables for installation method, workload ARM_CLIENT_ID, and Terraform state information

* Refactor deploy_controlplane.sh script to save deployer_tfstate_key in config information

* remove the deployer provider

* Refactor deploy_controlplane.sh script to use the azurerm.deployer provider for retrieving key vault secrets

* Refactor tfvar_variables.tf to add "tags" variable for providing tags to all resources

* Refactor providers.tf to use local variable for subscription_id in deployer provider

* Refactor providers.tf to remove subscription_id from deployer provider

* Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys

* Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys

* Refactor azurerm provider versions to 4.6.0

* Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys

* Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys

* Refactor deploy_controlplane.sh script to use local variables for deployer and library state file keys

* Refactor az keyvault set-policy command in deploy_controlplane.sh script

* Refactor az keyvault set-policy command in deploy_controlplane.sh script

* Add SPN to workload zone key vault

* Remove the permission setting from the pipeline

* Refactor echo statements in script_helpers.sh and installer.sh

* Refactor echo statements in script_helpers.sh and installer.sh

* Refactor echo statements in script_helpers.sh and installer.sh

* Refactor echo statements in script_helpers.sh and installer.sh

* Refactor echo statements in script_helpers.sh and installer.sh

* Refactor echo statements in script_helpers.sh and installer.sh

* Refactor echo statements in script_helpers.sh and installer.sh

* Refactor echo statements in deploy_utils.sh for better readability

* Refactor echo statement in 03-sap-system-deployment.yaml

* Refactor echo statement in 03-sap-system-deployment.yaml for better readability

* Refactor echo statement in 03-sap-system-deployment.yaml for better readability

* Refactor echo statements for better readability and consistency

* Refactor echo statements for better readability and consistency

* Refactor echo statements for better readability and consistency

* Refactor echo statements for better readability and consistency

* Refactor echo statements for better readability and consistency

* Refactor echo statements for better readability and consistency

* Refactor echo statements for better readability and consistency

* Refactor echo statements to use variable for workload TFvars

* Refactor echo statements to use variable for workload TFvars

* Refactor echo statements to use variable for workload TFvars

* Refactor echo statement to use variable for Terraform Storage Account Id

* Refactor echo statements to use variables for Terraform details

* Refactor echo statements to use variables for Terraform details

* Refactor echo statements to use variables for Terraform details

* Refactor echo statements to use variables consistently

* Refactor echo statements to use variables consistently

* Refactor echo statements to use variables consistently and for Terraform details

* Refactor echo statements to consistently use variables

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Debugging

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* trimming

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve formatting

* Refactor echo statements to consistently use variables and improve formatting

* terraform

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor echo statements to consistently use variables and improve formatting

* Refactor echo statements to consistently use variables and improve formatting

* Refactor echo statements to consistently use variables and improve Terraform details

* Refactor providers.tf to use Managed Service Identity (MSI) for authentication

* Refactor echo statements to consistently use variables and improve formatting

* Refactor echo statement to improve parameter file formatting

* Refactor echo statements to improve formatting and use variables consistently

* Refactor echo statements to consistently use variables and improve formatting

* Refactor deploy control plane pipeline to improve configuration and extension installation

* Refactor providers.tf to use remote state for subscription ID

* Refactor echo statements to consistently use variables and improve formatting

* Refactor echo statements to consistently use variables and improve formatting
Refactor providers.tf to use remote state for subscription ID
Refactor deploy control plane pipeline to improve configuration and extension installation
Fix validation issue in script_helpers.sh
Update providers.tf to handle null subscription ID
Remove unused variable in variables_local.tf

* Refactor echo statement to improve formatting in deploy_controlplane.sh

* Refactor echo statements to improve formatting in deploy_controlplane.sh and script_helpers.sh

* Refactor deploy_controlplane.sh and script_helpers.sh echo statements for improved formatting

* Refactor key vault secrets to include service principal access

* Refactor key vault secrets to include service principal access

* Refactor key vault secrets to include service principal access

* Refactor key vault secrets to include service principal access

* Refactor echo statements for improved formatting in deploy_controlplane.sh and script_helpers.sh

* Refactor permissions assignment in deploy_controlplane.sh

* Refactor echo statements for improved formatting and include deployer subscription

* Refactor echo statements for improved formatting and include deployer subscription

* Refactor echo statements for improved formatting and include deployer subscription

* Change to use ARM CLIENT ID

* Refactor echo statement to include deployer subscription in 02-sap-workload-zone.yaml

* Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml

* Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml

* Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml

* Refactor echo statements and include deployer subscription in 02-sap-workload-zone.yaml
Change to use WL_ARM_CLIENT_ID instead of ARM_CLIENT_ID
Update variable group and variable names in New-SDAFDevopsWorkloadZone.ps1
Update echo statements in script_helpers.sh for improved formatting

* Refactor echo statements for improved formatting and include deployer subscription in 02-sap-workload-zone.yaml

* Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml

* Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml

* indentation

* Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml

* Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml

* Refactor echo statements for improved formatting and include deployer subscription in 03-sap-system-deployment.yaml

* Refactor echo statements for improved formatting and fix indentation in 10-remover-terraform.yaml

* Refactor echo statement for improved formatting in remover.sh

* Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml

* Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml

* Refactor echo statements for improved formatting and remove unnecessary output in remover.sh and 10-remover-terraform.yaml

* Refactor echo statements for improved formatting and remove unnecessary output in 01-deploy-control-plane.yaml

* Refactor validate_dependencies function to check for the existence of the terraform binary file instead of the terraform directory.

* Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines

* Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines

* Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh

* Refactor azuread_service_principal data source to conditionally include object_id in locals

* Update SDAF version to 3.13.1.0 in ansible-input-api.yaml and version.txt

* Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines

* Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines

* Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy

* Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines

* Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy

* Refactor key_vault_sap_landscape.tf to conditionally include object_id in azurerm_key_vault_access_policy

* Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines

* Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines

* Refactor echo statements for improved formatting and remove unnecessary output in deploy and remove pipelines

* Refactor echo statements for improved formatting in installer.sh

* Refactor echo statements for improved formatting and remove unnecessary output in installer.sh

* Refactor echo statements for improved formatting and remove unnecessary output in set_secrets.sh

* Refactor echo statements for improved formatting and remove unnecessary output in installer.sh and providers.tf

* Refactor echo statements for improved formatting and remove unnecessary output in installer.sh

* Refactor installer.sh to fix path issue and pass parameters correctly

* Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call

* Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call

* Refactor deploy_controlplane.sh to include deployer subscription parameter and persist parameters

* Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call

* Refactor deploy_controlplane.sh to include state subscription parameter in installer.sh call

* Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call

* Refactor deploy_controlplane.sh to include correct subscription parameter in installer.sh call and handle storage account authentication

* Refactor deploy_controlplane.sh to remove unnecessary echo statement

* Refactor deploy_controlplane.sh to remove unnecessary echo statements and improve parameter handling

* Refactor deploy_controlplane.sh to improve parameter handling

* Refactor deploy_controlplane.sh to improve storage account authentication handling

* Refactor deploy_controlplane.sh to improve parameter handling and remove unnecessary echo statements

* Refactor deploy_utils.sh to fix variable value retrieval from config file

* Refactor parameter handling in script_helpers.sh and install_workloadzone.sh

* Refactor install_workloadzone.sh to handle unknown region codes

* Refactor install_workloadzone.sh to handle unknown region codes

* Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling

* Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling

* Refactor region code handling in deploy_utils.sh and script_helpers.sh

* Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling

* Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling

* Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling

* Refactor install_workloadzone.sh to handle unknown region codes and improve parameter handling

* Refactor install_workloadzone.sh to improve parameter handling and region code handling in deploy_utils.sh and script_helpers.sh

* Refactor install_workloadzone.sh to improve parameter handling and region code handling

* Refactor install_workloadzone.sh to improve parameter handling and region code handling

* Refactor install_workloadzone.sh to improve parameter handling and region code handling

* Refactor install_workloadzone.sh to improve parameter handling and region code handling

* Refactor install_workloadzone.sh to improve parameter handling and region code handling

* Refactor install_workloadzone.sh to remove unnecessary code

* Refactor echo statements to improve readability and consistency

* Refactor installer.sh to improve parameter handling and region code handling

* Refactor installer.sh to improve parameter handling and region code handling

* Refactor installer.sh to remove unnecessary echo statements

* Refactor installer.sh to improve parameter handling and region code handling

* Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition

* Refactor storage_accounts.tf to include var.use_private_endpoint in the count condition

* Keyvault network rules

* Refactor key_vault_sap_landscape.tf to include var.enable_firewall_for_keyvaults_and_storage in the default_action condition

* Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables

* Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables

* Refactor module.tf to include enable_firewall_for_keyvaults_and_storage variable

* Refactor installer.sh to handle empty SPN secret in set_executing_user_environment_variables and remove error file

* Add Terraform output detaisl

* Refactor Terraform plugin cache directory handling

* Refactor Terraform destroy command in remover.sh

* Refactor Terraform destroy command in remover.sh

* Refactor echo statement in deploy pipeline to include return code from deployment

* Refactor echo statement in deploy pipeline to include return code from deployment

---------

Co-authored-by: Kimmo Forss <[email protected]>
Co-authored-by: hdamecharla <[email protected]>
@hdamecharla
Fix conditional statement in install_workloadzone.sh
33bc56b
@KimForss @hdamecharla
Pipeline hotfixes (#654)
b823388 
* Refactor echo statements in deploy control plane pipeline
* Refactor install_workloadzone.sh script to reset return_value variable
* Refactor install_workloadzone.sh script to improve error handling
* feng shui
* Refactor variables_local.tf to improve readability and error handling
* Refactor deploy control plane pipeline to include deployer_tfstate_key parameter
* Refactor deploy control plane pipeline to include deployer_tfstate_key and landscape_tfstate_key parameters
* Refactor echo statement in deploy control plane pipeline
* Refactor remover script in deploy control plane pipeline
* Refactor deploy control plane pipeline to remove unnecessary use_msi flag
* Refactor deploy control plane pipeline to update default value for spn_keyvault_id
* Refactor deploy control plane pipeline to update default value for spn_key_vault_arm_id
* Refactor deploy control plane pipeline to trim deployer_tfstate_key in imports.tf
* Refactor deploy control plane pipeline to include provider for azurerm.workload in imports.tf
* Refactor deploy control plane pipeline to update storage account authentication and export TF_VAR_tfstate_resource_id
* Refactor deploy control plane pipeline to update deployer and landscape state file paths
* Refactor deploy control plane pipeline to remove unnecessary code in remover.sh
* Refactor install_workloadzone.sh to export SPN key vault ID if keyvault is provided
* Refactor tfvar_variables.tf to set default value of short_named_endpoints_nics to true
* Refactor remover.sh to consolidate terraform destroy command
* Refactor echo statements in remover.sh and remove-control-plane.yaml
* Refactor echo statements in deploy/pipelines/01-deploy-control-plane.yaml
* Refactor providers.tf to conditionally set use_msi based on var.use_spn
* Refactor echo statements in deploy/pipelines/01-deploy-control-plane.yaml to improve clarity of deployment credentials
* Refactor install_workloadzone.sh to improve argument parsing and readability
* Refactor code for improved argument parsing and readability in install_workloadzone.sh
* Refactor LandscapeModel.cs, LandscapeDetails.json, and LandscapeTemplate.txt to add prevent_deletion_if_contains_resources property
* Refactor package dependencies in os-packages.yaml
* Refactor ansible role to remove unused variable and update passlib dependency
* Refactor echo statement in install_workloadzone.sh for improved clarity

---------

Co-authored-by: Kimmo Forss <[email protected]>
@hjstam @hdamecharla
Add second frontend to HANA loadbalancer for active/read-enabled setup
2e4284c 
https://learn.microsoft.com/en-us/azure/sap/workloads/sap-hana-high-availability-rhel?tabs=lb-portal#configure-hana-activeread-enabled-system-replication-in-pacemaker-cluster
@hjstam @hdamecharla
Add support for HANA active/read-enabled system replication
2b8af37 
Configure HANA for logreplay_readaccess and set-up pacemaker with secondary virtual IP address resource for an active/read-enabled setup.

https://learn.microsoft.com/en-us/azure/sap/workloads/sap-hana-high-availability-rhel?tabs=lb-portal#configure-hana-activeread-enabled-system-replication
@hjstam @hdamecharla
Remove duplicate code and simplify 5.5-hanadb-pacemaker cluster Red Hat
00b3168
@hjstam @hdamecharla
Add support for HANA active/read-enabled system replication for SUSE
6728093
@hjstam @hdamecharla
Bugfix creation of sapadm user
2da6303 
sapadm user wasn't created anymore by SDAF. Updated the when statement and aligned user properties with sapinst.

Shell: /bin/false
Description: SAP System Administrator
@SteffenBoThomsen
New branch based of development for flow timeout and route propagation (
43ecff8 
#663)

- Add the option to specify *_flow_timeout_in_minutes for management and workload zone VNETs, defaults to null.
- Add the option to specify network_enable_route_propagation for subnet route tables, defaults to true.
@hdamecharla
Feature: Enable SAPHanaSR-angi configuration for scale-up configurati…
2d5a38d 
…ons (#664)

* feature: Enhance SAP HANA SR terraform configuration with new variable for SAPHanaSr-angi hook usage and output support

* feature: Add support for SLES 15.6 and introduce SAP HANA-SR ANGI configuration options. Some formatting and additional packages.
@hjstam
Add two node cluster properties for DB2 on RHEL8 (#665)
f164864 
Like with HANA and SCS/ERS we implement resource priority and set a fence delay of 15s on Db2 systems, to prevent both nodes from being fenced.
@KimForss
Pipeline and script improvements (#666)
2dce7a1 
* Script updates to handle move to storage accounts without data plane access

* Pipeline updates to ease debugging. Instead of using inline scripts the scripts are now in the file system

* Terraform updates to support the control plane access and to facilitate better importability of resources.

* Remove debug logging from control plane deployment script

---------

Co-authored-by: Kimmo Forss <[email protected]>
@KimForss @hdamecharla
Better support for Upgrades, compliance (#671)
747aad5 
* Refactor namespaces from AutomationForm to SDAFWebApp across models and views, remove the use_spn flag from the templates

* Add agent_network_id variable and update related configurations in SAP modules, bring in the updates related to active active deployments

* Enhance deployment scripts: add Azure account display, adjust directory creation permissions, and improve debug handling

* Refactor SAP installation pipeline: replace inline bash script with external script and adjust configuration path

* Refactor SAP installation media tasks: update allowSharedKeyAccess logic, improve debug output, and enhance command queries

* Enhance GitHub workflows: add Harden Runner step, update action versions, and introduce Dependabot configuration

* Update SDAF-General variable group: upgrade Terraform and Ansible core versions

* Update .gitignore to include user-specific and Visual Studio build files; modify RestHelper to use UTF-8 encoding for JSON content

---------

Co-authored-by: Kimmo Forss <[email protected]>
Co-authored-by: hdamecharla <[email protected]>
Fix: Update file path for DB and SAP installation preparation script
3ec7b59
Refactor: Standardize formatting for parameters in DB and SAP install…
1f0de4f 
…ation pipeline
Fix: Correct environment file name variable in DB and SAP installatio…
724ed6d 
…n preparation script
Fix: Update variable name from ARM_SUBSCRIPTION_ID to AZURE_SUBSCRIPT…
119b3ee 
…ION_ID in installation preparation script
Fix: Improve error handling in installation preparation scripts
18d846b
Fix: Correct environment file name variable in DB and SAP installatio…
ab97804 
…n preparation script

Fix: Update variable name from ARM_SUBSCRIPTION_ID to AZURE_SUBSCRIPTION_ID in installation preparation script

Fix: Improve error handling in installation preparation scripts
Merge branch 'development' of https://github.com/Azure/sap-automation …
202e64e 
…into development
Fix: Update variable group ID retrieval and improve directory navigat…
4bbd619 
…ion in installation preparation script
Add Ansible execution script with pre and post configuration tasks
8cc8770
Fix: Update variable names for ARM credentials in Terraform removal p…
f09a71a 
…ipeline and PowerShell script
Fix: Correct variable reference syntax in Ansible execution script
debac58
Fix: Correct variable reference syntax in Ansible execution script
86be0dd
Fix: Correct variable reference syntax in DB and SAP installation pre…
505caef 
…paration script
Fix: Update variable reference for environment in DB and SAP installa…
3734ca1 
…tion preparation script
Fix: Add CONTROL_PLANE_SUBSCRIPTION_ID parameter to DB and SAP instal…
b92cd22 
…lation and Ansible templates
Fix: Update download directory variable in Ansible execution script
cb37678
Fix: Update folder path variable in DB and SAP installation preparati…
ca7c53d 
…on script
Kimmo Forss and others added 15 commits December 9, 2024 13:33
Fix: Update download directory variable to use AGENT_TEMPDIRECTORY in…
b0d3e67 
… Ansible script
Fix: Remove unnecessary printenv command in Ansible execution script
4e4d75b
Fix: Refactor Ansible execution script to improve error handling and …
3565667 
…remove unused CONTROL_PLANE_SUBSCRIPTION_ID parameter
Fix: Correct variable name in condition check for Azure DevOps agent …
1f075e6 
…in Ansible YAML template
@hdamecharla
Fix: Update Ansible stdout callback to use YAML format
b457bd6
Fix: Disable certificate validation in BOM processing and utility tasks
8881713
Fix: Remove unnecessary printenv command from Ansible YAML template
89197b1
Merge branch 'development' of https://github.com/KimForss/sap-automation
57804fe 
 into development
@hdamecharla
Fix: Update Parameters and Reset Resources (#674)
d174d5c 
* ### Fix:
- Update `keepalive` parameter to uppercase.
- Set the priority to primary `IPaddr2` and `azure-lb` resource if `priority-fencing-delay` is configured.
- Perform `crm resource clear` to reset failcounts on resources.
- Clean up unused validation tasks.

* Refactor: Improve task definitions and add resource cleanup steps for 1.17 Generic Pacemaker

* Enhance BOM processing: Gather dependencies before processing and improve loop variable handling

* Update Ansible configuration: Switch stdout callback from JSON to YAML
@nnoaman
Add SAP CAL HA Integration
ec3768d
@nnoaman
Revert "Add SAP CAL HA Integration"
0a4b8bb 
This reverts commit ec3768d.
@KimForss
Hotfix/kimforss/release prep (#675)
36bb999 
* Fix: Update ANSIBLE_COLLECTIONS_PATH variable and adjust reboot timings in playbooks

* Fix: Update key vault commands to use lowercase vault names and remove VC++ 2013 component

* Fix: Adjust retry logic and delays in Ansible playbooks for improved reliability

* Refactor: Rename agent_network_id to additional_network_id and update related references, add IPTags  support, provide ability to specify the random the characters that will be appended to the resource names

* Fix: Update echo statements for clarity, correct ANSIBLE_COLLECTIONS_PATH variable, and improve error messages in deployment scripts

* Fix: Update ANSIBLE_COLLECTIONS_PATH variable in multiple YAML files for consistency

* Refactor: Adjust indentation and formatting in multiple model classes for improved readability

* Fix: Validate filename in FileController and update subscription_id references in site.js for consistency

---------

Co-authored-by: Kimmo Forss <[email protected]>
@KimForss @hdamecharla
Add copyright notices and licensing information to scripts and config… (
10c0520 
#676)

* Add copyright notices and licensing information to scripts and configuration files

* Enhance:
- Network rules for storage accounts and keyvaults by adding bypass options for Metrics, Logging, and AzureServices
- content type for keyvault secrets

---------

Co-authored-by: hdamecharla <[email protected]>
@hdamecharla
Refactor iSCSI configuration tasks for improved clarity and debugging (…
51f3dd9 
…#677)
@KimForss
Hotfix/pipelinescript fixes (#679)
1117b02 
- Parameter and Logging Enhancements: Added FORCE_RESET parameter and enhanced debug logging in control plane deployment pipeline. Also, added warning logs for forced re-install in control plane preparation script.
- Script Improvements: Refactored various scripts for consistency, readability, and error handling. This includes adding shebangs, fixing typos, and improving output formatting.
- Key Vault and Terraform Updates: Updated Key Vault configurations, enhanced logging for remote Terraform state management, and added dependencies for proper sequencing and resource creation.
- Resource Management: Removed unnecessary dependencies and variables, such as DEPLOYER_RANDOM_ID and LIBRARY_RANDOM_ID, and improved handling of custom random IDs.
- Error Handling and Output Management: Improved error handling and output management across multiple scripts, ensuring proper return value assignments and clear messaging for Terraform commands.

---------

Co-authored-by: Kimmo Forss <[email protected]>
@hdamecharla hdamecharla requested a review from KimForss December 31, 2024 16:06
@hdamecharla hdamecharla self-assigned this Dec 31, 2024
@hdamecharla hdamecharla requested a review from a team as a code owner December 31, 2024 16:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 31, 2024
View reviewed changes
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +217 to +238
resource "azurerm_key_vault_secret" "subscription" {
count = !var.key_vault.kv_exists ? (1) : (0)

depends_on = [
azurerm_key_vault_access_policy.kv_user_pre_deployer[0],
azurerm_key_vault_access_policy.kv_user_msi,
azurerm_key_vault_access_policy.kv_user_systemidentity,
azurerm_key_vault_access_policy.kv_user_additional_users
]

name = format("%s-subscription-id", upper(var.infrastructure.environment))
value = data.azurerm_client_config.deployer.subscription_id
key_vault_id = var.key_vault.kv_exists ? (
var.key_vault.kv_user_id) : (
azurerm_key_vault.kv_user[0].id
)

expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)
}

Check notice

Code scanning / Trivy

Key vault Secret should have a content type set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0015
Severity: LOW
Message: Secret does not have a content-type specified.
Link: AVD-AZU-0015
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +217 to +238
resource "azurerm_key_vault_secret" "subscription" {
count = !var.key_vault.kv_exists ? (1) : (0)

depends_on = [
azurerm_key_vault_access_policy.kv_user_pre_deployer[0],
azurerm_key_vault_access_policy.kv_user_msi,
azurerm_key_vault_access_policy.kv_user_systemidentity,
azurerm_key_vault_access_policy.kv_user_additional_users
]

name = format("%s-subscription-id", upper(var.infrastructure.environment))
value = data.azurerm_client_config.deployer.subscription_id
key_vault_id = var.key_vault.kv_exists ? (
var.key_vault.kv_user_id) : (
azurerm_key_vault.kv_user[0].id
)

expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)
}

Check notice

Code scanning / Trivy

Key vault Secret should have a content type set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0015
Severity: LOW
Message: Secret does not have a content-type specified.
Link: AVD-AZU-0015
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +234 to +237
expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)

Check notice

Code scanning / Trivy

Key Vault Secret should have an expiration date set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0017
Severity: LOW
Message: Secret should have an expiry date specified.
Link: AVD-AZU-0017
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +234 to +237
expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)

Check notice

Code scanning / Trivy

Key Vault Secret should have an expiration date set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0017
Severity: LOW
Message: Secret should have an expiry date specified.
Link: AVD-AZU-0017
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +321 to +324
expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)

Check notice

Code scanning / Trivy

Key Vault Secret should have an expiration date set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0017
Severity: LOW
Message: Secret should have an expiry date specified.
Link: AVD-AZU-0017
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +342 to +345
expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)

Check notice

Code scanning / Trivy

Key Vault Secret should have an expiration date set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0017
Severity: LOW
Message: Secret should have an expiry date specified.
Link: AVD-AZU-0017
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +370 to +373
expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)

Check notice

Code scanning / Trivy

Key Vault Secret should have an expiration date set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0017
Severity: LOW
Message: Secret should have an expiry date specified.
Link: AVD-AZU-0017
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +370 to +373
expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)

Check notice

Code scanning / Trivy

Key Vault Secret should have an expiration date set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0017
Severity: LOW
Message: Secret should have an expiry date specified.
Link: AVD-AZU-0017
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +399 to +402
expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)

Check notice

Code scanning / Trivy

Key Vault Secret should have an expiration date set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0017
Severity: LOW
Message: Secret should have an expiry date specified.
Link: AVD-AZU-0017
deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Comment on lines +399 to +402
expiration_date = var.set_secret_expiry ? (
time_offset.secret_expiry_date.rfc3339) : (
null
)

Check notice

Code scanning / Trivy

Key Vault Secret should have an expiration date set Low

Artifact: deploy/terraform/terraform-units/modules/sap_deployer/key_vault.tf
Type: terraform
Vulnerability AVD-AZU-0017
Severity: LOW
Message: Secret should have an expiry date specified.
Link: AVD-AZU-0017
@KimForss KimForss merged commit 911b685 into main Dec 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimForss KimForss KimForss approved these changes

Assignees

@hdamecharla hdamecharla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hdamecharla @KimForss @hjstam @SteffenBoThomsen @nnoaman