Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Upgrades, compliance #671

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

KimForss
Copy link
Collaborator

@KimForss KimForss commented Dec 4, 2024

This pull request includes several updates to GitHub Actions workflows, dependency management, and namespace changes in the Webapp/SDAF project. The most important changes are listed below, grouped by theme.

Terraform updates:

  • Ensured that upgrading from older deployments work seamlessly. To support storage accounts without access keys update the scripts to remove the affected resources from the state file and reimporting to update the schema

GitHub Actions Workflows:

  • Added a new dependabot.yml configuration to automate dependency updates for GitHub Actions, NuGet, and npm.
  • Introduced a codeql.yml workflow for CodeQL analysis to detect vulnerabilities in C#, JavaScript, and Python code.
  • Added a dependency-review.yml workflow to scan dependency manifest files for known vulnerabilities in pull requests.
  • Updated the ossf-scorecard.yml workflow to include the harden-runner step and updated several action versions. [1] [2] [3]
  • Added a trivy.yml workflow for running Trivy vulnerability scans on pull requests.

Dependency Management:

  • Updated .pre-commit-config.yaml to include hooks for gitleaks, shellcheck, eslint, end-of-file-fixer, trailing-whitespace, and pylint.
  • Updated the dotnet-ef tool version from 7.0.0 to 9.0.0 in dotnet-tools.json.

Namespace Changes:

Solution

Tests

Notes

Kimmo Forss added 7 commits December 4, 2024 23:23
…nd views, remove the use_spn flag from the templates
…P modules, bring in the updates related to active active deployments
…ry creation permissions, and improve debug handling
…xternal script and adjust configuration path
…gic, improve debug output, and enhance command queries
…ons, and introduce Dependabot configuration
@KimForss KimForss added the hotfix Hotfixes for issues with the solution. label Dec 4, 2024
@KimForss KimForss requested a review from hdamecharla December 4, 2024 22:09
@KimForss KimForss self-assigned this Dec 4, 2024
@KimForss KimForss marked this pull request as ready for review December 4, 2024 22:09
@KimForss KimForss requested a review from a team as a code owner December 4, 2024 22:09
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Webapp/SDAF/Controllers/RestHelper.cs Dismissed Show dismissed Hide dismissed
…les; modify RestHelper to use UTF-8 encoding for JSON content
Copy link
Member

@hdamecharla hdamecharla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hdamecharla hdamecharla merged commit 747aad5 into Azure:development Dec 5, 2024
9 checks passed
@hdamecharla hdamecharla deleted the hotfix/kimforss branch December 5, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Hotfixes for issues with the solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants