Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update Parameters and Reset Resources #674

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Fix: Update Parameters and Reset Resources #674

merged 4 commits into from
Dec 9, 2024

Conversation

hdamecharla
Copy link
Member

@hdamecharla hdamecharla commented Dec 6, 2024 •
edited
Loading

Problem

  • This PR addresses the issue where the keepalive parameter was not in uppercase, causing inconsistencies.
  • On RHEL based systems with active/read-enabled system replication when priority-fencing-delay was configured there is possibility of race conditions when priority for IPaddr2 and azure-lb is not set.
  • There were also fail counts on resources that needed to be reset, and
  • Unused validation tasks that required cleanup.

Solution

  • Updated the keepalive parameter to uppercase.
  • Set the priority to primary IPaddr2 and azure-lb resources if priority-fencing-delay is configured.
  • Performed crm resource clear to reset failcounts on resources.
  • Cleaned up unused validation tasks.

Tests

  1. Verify that the keepalive parameter is now in uppercase.
  2. Check that the priority is correctly set for IPaddr2 and azure-lb resources when priority-fencing-delay is configured.
  3. Ensure that crm resource clear successfully resets failcounts on resources.
  4. Confirm that unused validation tasks have been removed.

Notes

  • This PR aims to improve system stability and resource management.
  • Please review the changes and provide feedback.

Issues Closed

Closes #673

@hdamecharla
### Fix:
3144ef7 
- Update `keepalive` parameter to uppercase.
- Set the priority to primary `IPaddr2` and `azure-lb` resource if `priority-fencing-delay` is configured.
- Perform `crm resource clear` to reset failcounts on resources.
- Clean up unused validation tasks.
@hdamecharla hdamecharla requested a review from KimForss December 6, 2024 13:48
@hdamecharla hdamecharla self-assigned this Dec 6, 2024
@hdamecharla hdamecharla marked this pull request as ready for review December 9, 2024 10:35
@hdamecharla hdamecharla requested a review from a team as a code owner December 9, 2024 10:35
@KimForss KimForss merged commit d174d5c into Azure:development Dec 9, 2024
9 checks passed
KimForss pushed a commit to KimForss/sap-automation that referenced this pull request Dec 31, 2024
@hdamecharla
Fix: Update Parameters and Reset Resources (Azure#674)
ca30b55 
* ### Fix:
- Update `keepalive` parameter to uppercase.
- Set the priority to primary `IPaddr2` and `azure-lb` resource if `priority-fencing-delay` is configured.
- Perform `crm resource clear` to reset failcounts on resources.
- Clean up unused validation tasks.

* Refactor: Improve task definitions and add resource cleanup steps for 1.17 Generic Pacemaker

* Enhance BOM processing: Gather dependencies before processing and improve loop variable handling

* Update Ansible configuration: Switch stdout callback from JSON to YAML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimForss KimForss KimForss approved these changes

Assignees

@hdamecharla hdamecharla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdamecharla @KimForss