Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: remove make install-cert-manager for verify_deployment #102

Merged
merged 1 commit into from
Jul 20, 2021
Merged

e2e: remove make install-cert-manager for verify_deployment #102

merged 1 commit into from
Jul 20, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jul 20, 2021

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Removes make install-cert-manager from verify_deployment.
  • Removes the windows node taint that was required when using cert-manager

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

- Removes `make install-cert-manager` from verify_deployment.
- Removes the windows node taint that was required when using
  cert-manager

Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase marked this pull request as ready for review July 20, 2021 16:44
@aramase aramase requested a review from chewong July 20, 2021 16:44
@aramase aramase enabled auto-merge (squash) July 20, 2021 16:44
@aramase aramase merged commit 9d15d92 into Azure:main Jul 20, 2021
@chewong chewong deleted the deployment-yaml-e2e branch July 20, 2021 16:56
chewong pushed a commit that referenced this pull request Jul 22, 2021
chewong pushed a commit that referenced this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants