fix: do not taint windows nodes before upgrading the cluster #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewong
force-pushed
the
revert-102-deployment-yaml-e2e
branch
from
4dfb153 to
1130c52
Compare
aramase
reviewed
Jul 22, 2021
Signed-off-by: Ernest Wong <[email protected]>
chewong
force-pushed
the
revert-102-deployment-yaml-e2e
branch
from
1130c52 to
02c89d3
Compare
chewong
changed the title
make install-cert-manager for verify_deployment"
chewong
force-pushed
the
revert-102-deployment-yaml-e2e
branch
2 times, most recently
from
b4af163 to
02c89d3
Compare
aramase
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #102 to fix test failures in https://dev.azure.com/AzureContainerUpstream/AAD%20Pod%20Managed%20Identity/_build?definitionId=333. We need to taint the Windows node to prevent the webhook controller from scheduling to it.Realized that there is a step in nightly.yaml where the Windows node is tainted and since the untaint statement was removed in #102, we weren't able to schedule any Windows workload to it without any tolerations.