Skip to content

Commit

Permalink
e2e: remove make install-cert-manager for verify_deployment (#102)
Browse files Browse the repository at this point in the history
- Removes `make install-cert-manager` from verify_deployment.
- Removes the windows node taint that was required when using
  cert-manager

Signed-off-by: Anish Ramasekar <[email protected]>
  • Loading branch information
aramase authored Jul 20, 2021
1 parent 7845d70 commit 9d15d92
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
2 changes: 0 additions & 2 deletions .pipelines/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ jobs:
env:
SKIP_PREFLIGHT: "true"
SERVICE_ACCOUNT_ISSUER: $(SERVICE_ACCOUNT_ISSUER)
- script: make install-cert-manager
displayName: Installing cert-manager
- script: |
sed -i "s/AZURE_TENANT_ID: .*/AZURE_TENANT_ID: ${AZURE_TENANT_ID}/" manifest_staging/deploy/aad-pi-webhook.yaml
sed -i "s/AZURE_ENVIRONMENT: .*/AZURE_ENVIRONMENT: AzurePublicCloud/" manifest_staging/deploy/aad-pi-webhook.yaml
Expand Down
5 changes: 0 additions & 5 deletions scripts/ci-e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ create_cluster() {
WINDOWS_NODE_NAME="$(${KUBECTL} get node --selector=kubernetes.io/os=windows -ojson | jq -r '.items[0].metadata.name')"
if [[ "${WINDOWS_NODE_NAME}" == "null" ]]; then
unset WINDOWS_NODE_NAME
else
# taint the windows node to prevent cert-manager pods from scheduling to it
${KUBECTL} taint nodes "${WINDOWS_NODE_NAME}" kubernetes.io/os=windows:NoSchedule --overwrite
fi

if [[ "${REGISTRY}" =~ \.azurecr\.io ]]; then
Expand Down Expand Up @@ -88,8 +85,6 @@ main() {
sleep 120

if [[ -n "${WINDOWS_NODE_NAME:-}" ]]; then
# remove the taint from the windows node we introduced above
${KUBECTL} taint nodes "${WINDOWS_NODE_NAME}" kubernetes.io/os=windows:NoSchedule-
E2E_ARGS="--node-os-distro=windows ${E2E_ARGS:-}"
export E2E_ARGS
fi
Expand Down

0 comments on commit 9d15d92

Please sign in to comment.