[Test Proxy] Fix typo - Update RecordMatcher.cs #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
approved these changes
May 11, 2023
HarshaNalluru
added a commit
that referenced
this pull request
May 11, 2023
Ignoring the "Accept-Language" header @timovv shared the discomfort about the number of times he had to re-record because his locale is en-CA instead of en-US. And @jeremymeng 's puppeteer upgrade may unveil a pain later on, example below ``` RecorderError: Unable to find a record for the request POST https://keyvault_name.vault.azure.net/keys/listKeyName-cangettheversionsofakeypaged-/create?api-version=7.4 Header differences: <sec-ch-ua> values differ, request <"HeadlessChrome";v="113", "Chromium";v="113", "Not-A.Brand";v="24">, record <> <Accept-Language> is absent in request, value <en-US> Body differences: ``` `sec-ch-ua` is just fixed in #6151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History
In order to skip matching the browser's dynamic headers for our recordings, we skipped the headers listed in #2185 (comment)
And this was Scott's reaction and the typo crept in
[Test-Proxy] Header Exclusion Updates by scbedd · Pull Request #2317 · Azure/azure-sdk-tools (github.com)
Context on how we found it
@jeremymeng was upgrading the puppeteer version and the
"sec-ch-ua"header mismatch occurred, and @timovv pointed out the list.We could've used a sanitizer, but fixing the source feels righteous.