[Test-Proxy] Don't match on x-ms-useragent
#2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
commented
Oct 28, 2021
| @@ -7,6 +7,7 @@ | |||
| <IsPackable>true</IsPackable> | |||
| <PackAsTool>true</PackAsTool> | |||
| <ToolCommandName>test-proxy</ToolCommandName> | |||
| <LangVersion>9.0</LangVersion> | |||
There was a problem hiding this comment.
Intentional change. Given that the default build version in azure-sdk-tools is core 3.1, max language version supported is C# 8.0.
This package is built on .NET 5.0.XX, so we need to override the props file with the version necessary for us, which is 9.0. We make use of is not null :).
mccoyp
approved these changes
Oct 29, 2021
| @@ -38,6 +38,7 @@ public RecordMatcher(bool compareBodies = true) | |||
| "x-ms-date", | |||
| "x-ms-client-request-id", | |||
| "User-Agent", | |||
| "x-ms-useragent", | |||
There was a problem hiding this comment.
marking more exclusions to consider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually already treat the header
User-Agentas volatile, so this isn't even a departure from what the test-proxy already does. Just an extension of it.@HarshaNalluru