Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test-Proxy] Don't match on x-ms-useragent #2185

Merged
merged 2 commits into from
Oct 29, 2021
Merged

[Test-Proxy] Don't match on x-ms-useragent #2185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
562869e
add x-ms-useragent to the set of headers that we don't care to match on.
scbedd Oct 28, 2021
9a53451
force latest language version
scbedd Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/test-proxy/Azure.Sdk.Tools.TestProxy/Azure.Sdk.Tools.TestProxy.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<IsPackable>true</IsPackable>
<PackAsTool>true</PackAsTool>
<ToolCommandName>test-proxy</ToolCommandName>
<LangVersion>9.0</LangVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional change. Given that the default build version in azure-sdk-tools is core 3.1, max language version supported is C# 8.0.

This package is built on .NET 5.0.XX, so we need to override the props file with the version necessary for us, which is 9.0. We make use of is not null :).

</PropertyGroup>
<ItemGroup>
<PackageReference Include="Azure.Core" Version="1.10.0" />
Expand Down
2 changes: 2 additions & 0 deletions tools/test-proxy/Azure.Sdk.Tools.TestProxy/Common/RecordMatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public RecordMatcher(bool compareBodies = true)
"x-ms-date",
"x-ms-client-request-id",
"User-Agent",
"x-ms-useragent",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking more exclusions to consider
image

"Request-Id",
"traceparent"
};
Expand All @@ -49,6 +50,7 @@ public RecordMatcher(bool compareBodies = true)
"x-ms-date",
"x-ms-client-request-id",
"User-Agent",
"x-ms-useragent",
"Request-Id",
"If-Match",
"If-None-Match",
Expand Down