-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Proxy] Add "Accept-Language" header to the ignore list - Update RecordMatcher.cs #6152
Conversation
Ignoring the "Accept-Language" header @timovv shared the discomfort about the number of times he had to re-record because his locale is en-CA instead of en-US. And @jeremymeng 's puppeteer upgrade may unveil a pain later on, example below ``` RecorderError: Unable to find a record for the request POST https://keyvault_name.vault.azure.net/keys/listKeyName-cangettheversionsofakeypaged-/create?api-version=7.4 Header differences: <sec-ch-ua> values differ, request <"HeadlessChrome";v="113", "Chromium";v="113", "Not-A.Brand";v="24">, record <> <Accept-Language> is absent in request, value <en-US> Body differences: ``` `sec-ch-ua` is just fixed in #6151
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Going to talk to Mike about this one.
Upon discussing more with @scbedd.. The issue posted above won't be fixed by adding to the ignore headers... And excluding feels wrong as there might be real utility. cc @jeremymeng Making it a draft until we conclude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding off.
Hi @HarshaNalluru. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @HarshaNalluru. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Ignoring the
"Accept-Language"
header@timovv shared the discomfort about the number of times he had to re-record because his locale is en-CA instead of en-US.
And @jeremymeng 's puppeteer upgrade may unveil a pain later on, example below
sec-ch-ua
is just fixed in #6151