Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial package for readme verification. #1

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Feb 14, 2019

@Azure/azure-sdk-eng

doc-warden has tested successfully on python 2.7 and 3.6.

Other bookkeeping:

  • Updating root readme

Example usage: Azure/azure-sdk-for-python#4365

@weshaggard
Copy link
Member

@scbedd do we expect to setup a CI for this repo as well or will the builds just be manually done? While I want to say setup a CI I worry about what might happen if we start needing toolsets for lots of different languages etc when we add more tools. However I think having CI outweighs that risk, at least for now :)

@scbedd
Copy link
Member Author

scbedd commented Feb 14, 2019

@weshaggard I actually deliberately placed the package into a python-packages folder, so it will be separate from the the others and easy to handle in CI.

If we were to add a NPM package, or C#, or whatever else, we'd put them in a <language>-packages folder.

@scbedd scbedd changed the title adding doc-warden to the packages folder. updating readme with index. Adding initial package for readme verification. Feb 14, 2019
@bsiegel
Copy link
Member

bsiegel commented Feb 15, 2019

Looks reasonable to me! :shipit:

@scbedd scbedd merged commit d269689 into Azure:master Feb 15, 2019
scbedd added a commit to scbedd/azure-sdk-tools that referenced this pull request Apr 29, 2019
arpanlaha added a commit to arpanlaha/azure-sdk-tools that referenced this pull request Jun 14, 2019
mitchdenny added a commit that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants