Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of API Readiness App to improve usability and address gaps in engagement experience data model #8063

Open
1 task
Tracked by #7822
ladonnaq opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience

Comments

@ladonnaq
Copy link
Member

ladonnaq commented Apr 10, 2024

The API readiness milestone app currently requires a user to go through all steps, which is not always necessary. The GitHub toolchain drives the API Review process via the API Spec pull request (PR). The API readiness milestone should be used to validate that the checks and approvers needed to begin the SDK pre-release work have been completed. These checks/approvers should also be requirements to merge the PR.

This work item is related to this epic. #5670
TODO: Rewrite this issue to reflect the changes we want to make to the API Readiness App to reduce complexity and improve the user experience

Relevant GitHub issues:

Pre-release work:

Management Plane

  1. If new initial SDK, then the SDK package namespaces for each language must be reviewed and approved by the arch board.
  2. .NET SDK must be generated, samples generated, and testing completed. (Dependent upon completion of Adding initial package for readme verification. #1)

Data Plane

  1. If new initial SDK, then the SDK package namespaces for each language must be reviewed and approved by the arch board.
  2. All SDKs must be generated, samples written, and testing completed (Dependent upon completion of Adding initial package for readme verification. #1)

Checks and approvers

In API Readiness today
Images show the current checks and approvers in the API readiness milestone

  1. These checks are the same for management and data plane.
image 2. SDK Breaking Changes is only in management plane. In my recent interactions with service partners, they are finding to navigate the PR and figure out what they should address first. I think that if there are breaking changes, we should alert the user in the release planner. If there are no breaking changes, we skip showing them anything. image 3. The signoff screen is different for data plane vs management plane. image

Gaps in data model

Tasks

Preview Give feedback
@maririos
Copy link
Member

Looking into this issue and after conversations with the team, I think it will be beter if we:

  • Management plane: Hide the steps: Cleanup validation errors, review breaking changes, Preview API docs, and ARM API Review. These steps should be handled by the spec PR itself. The Sign off step currently shows the status of those checks. We can probably just show that.
  • Data plane: Hide the steps: Cleanup spec validation errors and Set up API preview docs. Same reason as for management plane

@maririos maririos added the Central-EngSys This issue is owned by the Engineering System team. label Apr 22, 2024
@ladonnaq ladonnaq moved this from New to Backlog in Engagement Experience Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience
Projects
Status: 🤔 Triage
Status: Backlog
Development

No branches or pull requests

2 participants