Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show errors in the clean up validation errors screen of the API readiness app #5670

Open
1 of 2 tasks
Tracked by #5566
ladonnaq opened this issue Mar 9, 2023 · 6 comments
Open
1 of 2 tasks
Tracked by #5566

Comments

@ladonnaq
Copy link
Member

ladonnaq commented Mar 9, 2023

  • Earlier in the UI flow the user selects Cadl/TypeSpec or swagger. If they selected swagger don't display information on Clean Up Validation screen.
  • The Cadl is currently used to identify PRs that are for Cadl. We should identify if this label name will change to TypeSpec and will continue to be used. If so, if we have the PR then we don't need to ask the user as we could look for the label.

image

@maririos
Copy link
Member

maririos commented Apr 4, 2023

This comes directly from the specs repo.
Options are:

  1. Show only the failure jobs, and an option for view more. If everything is good show message we are all good :)
  2. Filter the jobs we care about here (and in this case see if there was no Cadl, no show that job)

@maririos maririos moved this from New to Backlog in Engagement Experience Apr 4, 2023
@ladonnaq
Copy link
Member Author

ladonnaq commented May 8, 2023

This comes directly from the specs repo. Options are:

  1. Show only the failure jobs, and an option for view more. If everything is good show message we are all good :)
  2. Filter the jobs we care about here (and in this case see if there was no Cadl, no show that job)

I think it may make sense to only show if something failed with link to the details as well as the "request suppression" if it is something that a service team may request suppression. We should explain what "request suppression" means and what happens if the user selects the button. If nothing failed, then show a message stating that all validations have passed, and the user continues through the steps.

@ladonnaq ladonnaq changed the title When the management plane API Spec is not described using TypeSpec/Cadl do not have info on the Clean Up Validation screen. Only show errors in the clean up validation errors screen of the API readiness app May 8, 2023
@maririos
Copy link
Member

maririos commented May 8, 2023

FYI @praveenkuttappan this is somehow related to the issue you are currently looking into

@praveenkuttappan praveenkuttappan self-assigned this May 18, 2023
@praveenkuttappan praveenkuttappan moved this from Backlog to In Progress in Engagement Experience May 18, 2023
@maririos
Copy link
Member

@ladonnaq will you be ok if we don't do this issue until the work for the new UI happens?

@ladonnaq
Copy link
Member Author

@maririos Do we need to move this GitHub issue to an epic that we are tracking the updated UI for the API readiness app? We would also want to rewrite it so that it reflects what we want now (since this issue was open in March and many things have changed).

@maririos
Copy link
Member

@maririos Mariana Rios Flores FTE Do we need to move this GitHub issue to an epic that we are tracking the updated UI for the API readiness app?

it already is: #5566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants