Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple failures in azure-rest-api-specs-pr pipelines #2937

Closed
mikekistler opened this issue Mar 21, 2022 · 7 comments
Closed

Multiple failures in azure-rest-api-specs-pr pipelines #2937

mikekistler opened this issue Mar 21, 2022 · 7 comments
Assignees
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikekistler
Copy link
Member

In email from @pvrk regarding https://github.com/Azure/azure-rest-api-specs-pr/pull/5524

We have made the changes that were discussed in last review meeting, But facing below errors in the PR.
 
1. Go SDK generation is failing in autorest· [https://github.com/Azure/azure-rest-api-specs-pr/pull/5524/checks?check_run_id=56231090622](https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs-pr%2Fpull%2F5524%2Fchecks%3Fcheck_run_id%3D56231090622&data=04%7C01%7Cmikekistler%40microsoft.com%7C76beec2a3a0b404b971a08da0b328455%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637834608905187474%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2Fn2UcKrkj7yVEzhx7GF4mx%2FLYl0Tf2%2FuHkA%2BXrDiQvU%3D&reserved=0).
2. Swagger SDK Breaking Change Tracking is failing, although, this is first ever PR. Its incorrectly comparing with our management set of APIs. [https://github.com/Azure/azure-rest-api-specs-pr/pull/5524/checks?check_run_id=56230935833](https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs-pr%2Fpull%2F5524%2Fchecks%3Fcheck_run_id%3D56230935833&data=04%7C01%7Cmikekistler%40microsoft.com%7C76beec2a3a0b404b971a08da0b328455%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637834608905187474%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Vg9X3%2FgqxAxWMs4yl4QbAMhYtv09kU83VqWJiSoftmE%3D&reserved=0).
3. Pretty print checks are passing on the local run for same set of files. How can we check exact errors locally to fix?
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 21, 2022
@weshaggard weshaggard added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Mar 21, 2022
@kurtzeborn kurtzeborn removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 21, 2022
@akning-ms
Copy link

akning-ms commented Mar 23, 2022

@ruowan to take a look # 2 # 3,
@weshaggard for # 1, do you know who own GO SDK generation for dataplane?

@mikekistler
Copy link
Member Author

@RickWinter owns Go SDK generation for dataplane.

@Petermarcu
Copy link
Member

@jhendrixMSFT as FYI

@jhendrixMSFT
Copy link
Member

I reran the failed the job for whatever reason the logs aren't accessible. At any rate, as this is executing the track 1 code generator, and we no longer generate data-plane for track 1, can we remove this step?

@akning-ms
Copy link

for 1, go sdk track1 code gen should already removed, @dw511214992 to confirm and check above 2,

@dw511214992
Copy link
Member

The PR is a dataplane PR, and it shouldn't include azure-sdk-for-go in readme.md because azure-sdk-for-go doesn't support generating dataplane sdk in sdk automation pipeline.

About the sdk breaking change tracking ci, I think the PR change the swaggers in mgmt folder, and go sdk pipeline generates breaking change in mgmt sdk side. Although the PR changes to store the swaggers in data-plane folder, the original generated breaking change cannot be moved because the sdk breaking change tracking ci's architecture restriction.

Moreoever, azure-sdk-for-net should be changed to azure-sdk-for-net-track2

I have added comment to the PR.

@raych1 raych1 moved this from In Progress to Done in Spec PR Tools Jun 28, 2022
@raych1
Copy link
Member

raych1 commented Jun 28, 2022

I assume @dw511214992 resolved this issue with his comment in the associated PR. Feel free to re-open this issue if necessary.

@raych1 raych1 closed this as completed Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 🎊 Closed
Development

No branches or pull requests

8 participants