Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update min version of azure-mgmt-core in shared reqs #23374

Merged
merged 3 commits into from
Mar 7, 2022
Merged

update min version of azure-mgmt-core in shared reqs #23374

merged 3 commits into from
Mar 7, 2022

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented Mar 7, 2022 •
edited
Loading

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1414764&view=results

This PR: #23332
bumped the azure-mgmt-core version for most, but not all mgmt packages. The shared reqs needs to be updated to reflect that.

@kristapratico kristapratico changed the title update min version of azure-mgmt-core update min version of azure-mgmt-core in shared reqs Mar 7, 2022
@check-enforcer
Copy link

check-enforcer bot commented Mar 7, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@kristapratico
Copy link
Member Author

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@kristapratico kristapratico requested a review from mccoyp March 7, 2022 20:09
mccoyp
mccoyp approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting to this before me 🙂

@kristapratico
Copy link
Member Author

/check-enforcer override

@kristapratico kristapratico merged commit f694d2f into Azure:main Mar 7, 2022
@kristapratico kristapratico deleted the fixsharedreqs branch March 7, 2022 20:36
@xiangyan99
Copy link
Member

I created same PR. #23376:)

@kristapratico
Copy link
Member Author

I created same PR. #23376:)

Oh no! I missed that. We're all so on top of it 😄

iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 9, 2022
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
7b98b1d 
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (28 commits)
  [Storage] Fix duplicate type signatures in async (Azure#23375)
  Adds Env Var that overrides x-ms-useragent, to correct test pipeline (Azure#23310)
  [Key Vault] Arch board feedback and language alignment (Azure#23286)
  include txt sample files in package (Azure#23409)
  [KeyVault Admin] Add one perfstress test (Azure#23303)
  Increment version for search releases (Azure#23405)
  fix version on readme (Azure#23408)
  Increment version for identity releases (Azure#23407)
  [formrecognizer] Fix cspell issues (Azure#23313)
  Increment package version after release of azure-synapse-artifacts (Azure#23393)
  [pylint] dev_requirements.txt for pylint (Azure#23387)
  [Sql] Update sql tests (Azure#23398)
  code and test (Azure#23397)
  [Sql] Migrate sql tests to test proxy (Azure#23388)
  Update swagger to latest version (Azure#23377)
  Sync eng/common directory with azure-sdk-tools for PR 2875 (Azure#23379)
  [formrecognizer] Improve live pipeline tests (Azure#23239)
  update min version of azure-mgmt-core in shared reqs (Azure#23374)
  [CredScan] Suppress warnings for "username" string (Azure#23358)
  [synapse] regenerate `azure-synapse-artifacts` with tag `package-artifacts-composite-v3` (Azure#23295)
  ...
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
@kristapratico @rakshith91
update min version of azure-mgmt-core in shared reqs (Azure#23374)
3dd9995 
* update min version of azure-mgmt-core

* fix azure-mgmt-core req for libraries not updated

* remove overrides for libraries that match the frozen req
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@kristapratico @rakshith91
update min version of azure-mgmt-core in shared reqs (Azure#23374)
7cbdd6b 
* update min version of azure-mgmt-core

* fix azure-mgmt-core req for libraries not updated

* remove overrides for libraries that match the frozen req
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccoyp mccoyp mccoyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristapratico @xiangyan99 @mccoyp