-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Key Vault] Arch board feedback and language alignment #23286
Conversation
API changes have been detected in API changes - version: str = None,
+ version: Optional[str] = ...,
- version: str = None,
+ version: Optional[str] = ..., |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
API changes have been detected in |
1 similar comment
API changes have been detected in |
API changes have been detected in |
dec5995
to
ca4a069
Compare
API changes have been detected in |
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (28 commits) [Storage] Fix duplicate type signatures in async (Azure#23375) Adds Env Var that overrides x-ms-useragent, to correct test pipeline (Azure#23310) [Key Vault] Arch board feedback and language alignment (Azure#23286) include txt sample files in package (Azure#23409) [KeyVault Admin] Add one perfstress test (Azure#23303) Increment version for search releases (Azure#23405) fix version on readme (Azure#23408) Increment version for identity releases (Azure#23407) [formrecognizer] Fix cspell issues (Azure#23313) Increment package version after release of azure-synapse-artifacts (Azure#23393) [pylint] dev_requirements.txt for pylint (Azure#23387) [Sql] Update sql tests (Azure#23398) code and test (Azure#23397) [Sql] Migrate sql tests to test proxy (Azure#23388) Update swagger to latest version (Azure#23377) Sync eng/common directory with azure-sdk-tools for PR 2875 (Azure#23379) [formrecognizer] Improve live pipeline tests (Azure#23239) update min version of azure-mgmt-core in shared reqs (Azure#23374) [CredScan] Suppress warnings for "username" string (Azure#23358) [synapse] regenerate `azure-synapse-artifacts` with tag `package-artifacts-composite-v3` (Azure#23295) ...
Description
Resolves #22981:
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines