[CredScan] Suppress warnings for "username" string #23358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - containerregistry - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Pipeline run for Pipeline run for |
sima-zhu
approved these changes
Mar 5, 2022
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 9, 2022
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (28 commits) [Storage] Fix duplicate type signatures in async (Azure#23375) Adds Env Var that overrides x-ms-useragent, to correct test pipeline (Azure#23310) [Key Vault] Arch board feedback and language alignment (Azure#23286) include txt sample files in package (Azure#23409) [KeyVault Admin] Add one perfstress test (Azure#23303) Increment version for search releases (Azure#23405) fix version on readme (Azure#23408) Increment version for identity releases (Azure#23407) [formrecognizer] Fix cspell issues (Azure#23313) Increment package version after release of azure-synapse-artifacts (Azure#23393) [pylint] dev_requirements.txt for pylint (Azure#23387) [Sql] Update sql tests (Azure#23398) code and test (Azure#23397) [Sql] Migrate sql tests to test proxy (Azure#23388) Update swagger to latest version (Azure#23377) Sync eng/common directory with azure-sdk-tools for PR 2875 (Azure#23379) [formrecognizer] Improve live pipeline tests (Azure#23239) update min version of azure-mgmt-core in shared reqs (Azure#23374) [CredScan] Suppress warnings for "username" string (Azure#23358) [synapse] regenerate `azure-synapse-artifacts` with tag `package-artifacts-composite-v3` (Azure#23295) ...
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 7, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The remaining active CredScan warnings -- coming from
azure-mgmt-containerregistryandazure-mgmt-containerservice-- all seem to come from the presence of the string"username"in generated code. This is a little surprising, considering the string appears in... a lot of places, but CredScan knows more than me about why it's particularly suspicious in these files.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines