Add better autolockrenew on-failure handling capabilities. #12307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser-defined reason (e.g. not due to settlement or shutdown) a lock is lost on an auto-lock-renewed session or message. Adds tests as well and changelog notes.
KieranBrantnerMagee
added
Service Bus
Client
yunhaoling
reviewed
Jul 1, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 1, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 1, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 1, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 1, 2020
…able - add a test for receiver shutdown halting autorenewal (and corrosponding mocks) - Add proper typing and documentation to aio code.
…other comparable instances. Adjust tests/docs/guides/etc. Add changelog entry for the on lock renew callback.
… renwable and the optional error.
… with OOB changes. (param renames e.g. _lock_expired)
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Jul 20, 2020
annatisch
reviewed
Jul 20, 2020
annatisch
reviewed
Jul 20, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_async_auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
annatisch
reviewed
Jul 20, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/_common/auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
annatisch
previously approved these changes
Jul 20, 2020
…w; make tests be more precise by explicitly clearing results list between trials.
yunhaoling
reviewed
Jul 20, 2020
sdk/servicebus/azure-servicebus/samples/async_samples/auto_lock_renew_async.py
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 21, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_async_auto_lock_renewer.py
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 21, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/aio/_async_auto_lock_renewer.py
Outdated
Show resolved
Hide resolved
…or the callbacks, differentiate the async and sync autolockrenewer callback docstring.
…and sleep_duration internal.
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Pull request contains merge conflicts. |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 29, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits) rename FormField.type -> FormField.value_type (Azure#12708) 20200703 codereport (Azure#12361) Use the common Cosmos emulator template. (Azure#12678) Add azurestackhci ci.yml for pipeline generation. (Azure#12701) [ServiceBus] Resend received message (Azure#12457) AZURE_CLIENT_ID sets user-assigned managed identity for DefaultAzureCredential (Azure#12689) Add better autolockrenew on-failure handling capabilities. (Azure#12307) Update CODEOWNERS (Azure#12418) close client session in async tests (Azure#12656) Sync eng/common directory with azure-sdk-tools repository (Azure#12502) [Event Hubs] Use EventHubManagementClient to create test resources (Azure#12501) Increment package version after release of azure_identity (Azure#12675) [formrecognizer] include error code for errors that occur during polling (Azure#12621) Cross-language consistency changes (Azure#12669) Enable APIStubGen step (Azure#12615) Adding the ability to create a container with analytical storage turned on. (Azure#12408) [ServiceBus] Adjust user-agent following the guideline (Azure#12596) Release for Cognitive Services - Anomaly Detector (Azure#12582) [formrecognizer] Add type to FormField (Azure#12561) Add example summary for azure-identity readme.md (Azure#12509) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autolockrenewer can now take a callback that fires when for any non-user-defined reason (e.g. not due to settlement or shutdown) a lock is lost on an auto-lock-renewed session or message.
In doing so refactors autolockrenewer into its own file for better encapsulation, as it is effectively a stand-alone entity within the sdk.
Adds tests as well and changelog notes.